Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github-action: install synthetics for running the UTs in x-pack/heartbeat #38185

Merged
merged 2 commits into from
Mar 6, 2024
Merged

github-action: install synthetics for running the UTs in x-pack/heartbeat #38185

merged 2 commits into from
Mar 6, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Mar 5, 2024

Proposed commit message

  • WHAT: install the required dependency for running the UTs
  • WHY: there is a dependency to have installed the elastic/synthetics dependency and the mage build system just uses it.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@v1v v1v added backport-v8.12.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify labels Mar 5, 2024
@v1v v1v requested a review from a team March 5, 2024 09:24
@v1v v1v self-assigned this Mar 5, 2024
@v1v v1v requested a review from a team as a code owner March 5, 2024 09:24
@v1v v1v requested review from rdner and leehinman March 5, 2024 09:24
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 5, 2024
v1v
v1v commented Mar 5, 2024
View reviewed changes
.github/workflows/macos-xpack-heartbeat.yml
Comment on lines +20 to +21
- uses: actions/checkout@v4
- uses: actions/setup-go@v4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated... but worth to upgrade to the latest available versions

v1v
v1v commented Mar 5, 2024
View reviewed changes
.github/workflows/macos-xpack-heartbeat.yml Outdated
run: go install github.com/magefile/mage
run: |
go install github.com/magefile/mage
cd ${{ env.BEAT_MODULE }} && npm install @elastic/synthetics
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially, the Mage build system could be the one in charge of installing this particular dependency ... but that's something the heartbeat team might need to decide.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @v1v

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @v1v

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @v1v

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @v1v

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 5, 2024 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-03-05T09:33:42.958+0000

  • Duration: 12 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @v1v

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Mar 5, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 5, 2024
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @v1v

@rdner rdner merged commit 00e38f5 into main Mar 6, 2024
29 of 30 checks passed
@rdner rdner deleted the fix/macos-synthetics-dependency branch March 6, 2024 08:36
mergify bot pushed a commit that referenced this pull request Mar 6, 2024
@v1v @mergify
github-action: install synthetics for running the UTs in x-pack/heart…
4511353 
…beat (#38185)

* install globally

(cherry picked from commit 00e38f5)
mergify bot pushed a commit that referenced this pull request Mar 6, 2024
@v1v @mergify
github-action: install synthetics for running the UTs in x-pack/heart…
846037d 
…beat (#38185)

* install globally

(cherry picked from commit 00e38f5)
This was referenced Mar 6, 2024
Merged
Merged
v1v pushed a commit that referenced this pull request Mar 6, 2024
@mergify
github-action: install synthetics for running the UTs in x-pack/heart…
5c688fe 
…beat (#38185) (#38194)
v1v pushed a commit that referenced this pull request Mar 6, 2024
@mergify
github-action: install synthetics for running the UTs in x-pack/heart…
4d5aa6d 
…beat (#38185) (#38195)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@rdner rdner Awaiting requested review from rdner rdner was automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman was automatically assigned from elastic/elastic-agent-data-plane

Assignees

@v1v v1v

Labels
backport-v8.12.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v1v @elasticmachine @pierrehilbert @rdner