-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: enable synthetics tests for heartbeats #32710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'm not perhaps totally qualified to review CI stuff, but looks correct from what I can tell.
Thanks so much!
Thanks @andrewvc for the review, there are some questions regarding how to verify if those tests were executed, would you mind going through them so we can validate these changes run the expected tests? ScenariosFor
|
That's correct for now @v1v , our first integration test lands in this PR here: https://github.com/elastic/beats/pull/30632/files#diff-fc428ce882a18d78740376d34382dc5996f9908d014ec985f31b71d2a2ca11edR18 along with magefile improvements here: https://github.com/elastic/beats/pull/30632/files#diff-943c67c8c343aa1bdb9cf4ef7c141f388218835dc996232fec36d77970e05344R8 |
(cherry picked from commit 29fe9bb)
(cherry picked from commit 29fe9bb) Co-authored-by: Victor Martinez <[email protected]>
What
So, we'd want our CI boxes that run the unit tests for
x-pack/heartbeat
to:npm i -g @elastic/synthetics
installedELASTIC_SYNTHETICS_CAPABLE
flag set totrue
to signal that it can run these tests.Why
With #32542 we now have improved testing of browser based monitors in heartbeat. We don't, however, have a good way to run these tests using the actual synthetics node package. Heartbeat fork/execs the
elastic-synthetics
binary provided bynpm i -g @elastic/synthetics
to run browser monitors.Test
The first build ran the below steps:
heartbeat
NOTE: As requested it will not run on
heartbeat
butx-pack/heartbeat
only.This log is the one with the
npm i -g @elastic/synthetics
execution and this other log is the one with the traces for runningmage build unitTest
for thehearbeat
x-pack/heartbeat
whenmage unitTest
This log is the one with the traces for running
mage build unitTest
for thex-pack/hearbeat
, @andrewvc , can you please verify if that's the expected behaviour?x-pack/heartbeat
whenmage goIntegTest