Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.10](backport #36575) packetbeat/sniffer,packetbeat/protos/{tcp,udp}: prevent identical interfaces from colliding in metric namespace #36625

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 19, 2023

This is an automatic backport of pull request #36575 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…erfaces from colliding in metric namespace (#36575)

Configurations from fleet may contain multiple identical interfaces, when the
sniffers for each of these are constructed, they will attempt to register under
the same ID in the metrics collection namespace. This results in a panic. So
give each interface an internally unique index to decollide them.

(cherry picked from commit 622de0c)
@mergify mergify bot requested a review from a team as a code owner September 19, 2023 22:43
@mergify mergify bot added the backport label Sep 19, 2023
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 19, 2023
@botelastic
Copy link

botelastic bot commented Sep 19, 2023

This pull request doesn't have a Team:<team> label.

@mergify mergify bot assigned efd6 Sep 19, 2023
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-19T22:43:35.498+0000

  • Duration: 49 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 2361
Skipped 25
Total 2386

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 merged commit 5da7452 into 8.10 Sep 20, 2023
8 checks passed
@efd6 efd6 deleted the mergify/bp/8.10/pr-36575 branch September 20, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants