packetbeat/sniffer,packetbeat/protos/{tcp,udp}: prevent identical interfaces from colliding in metric namespace #36575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
Packetbeat
Team:Security-External Integrations
bugfix
8.11-candidate
backport-v8.10.0
botelastic
bot
added
needs_team
…erfaces from colliding in metric namespace Configurations from fleet may contain multiple identical interfaces, when the sniffers for each of these are constructed, they will attempt to register under the same ID in the metrics collection namespace. This results in a panic. So give each interface an internally unique index to decollide them.
efd6
force-pushed
the
36574-packetbeat_indexed_sniffers
branch
from
33b66a8 to
fa8fd11
Compare
3 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
7 tasks
andrewkroh
approved these changes
Sep 19, 2023
mergify bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
…erfaces from colliding in metric namespace (#36575) Configurations from fleet may contain multiple identical interfaces, when the sniffers for each of these are constructed, they will attempt to register under the same ID in the metrics collection namespace. This results in a panic. So give each interface an internally unique index to decollide them. (cherry picked from commit 622de0c)
efd6
added a commit
that referenced
this pull request
Sep 20, 2023
…erfaces from colliding in metric namespace (#36575) (#36625) Configurations from fleet may contain multiple identical interfaces, when the sniffers for each of these are constructed, they will attempt to register under the same ID in the metrics collection namespace. This results in a panic. So give each interface an internally unique index to decollide them. (cherry picked from commit 622de0c) Co-authored-by: Dan Kortschak <[email protected]>
Scholar-Li
pushed a commit
to Scholar-Li/beats
that referenced
this pull request
Feb 5, 2024
…erfaces from colliding in metric namespace (elastic#36575) Configurations from fleet may contain multiple identical interfaces, when the sniffers for each of these are constructed, they will attempt to register under the same ID in the metrics collection namespace. This results in a panic. So give each interface an internally unique index to decollide them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Configurations from fleet may contain multiple identical interfaces, when the sniffers for each of these are constructed, they will attempt to register under the same ID in the metrics collection namespace. This results in a panic. So give each interface an internally unique index to decollide them.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs