Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all Dockerfiles that use Golang into the bump job #35931

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

rdner
Copy link
Member

@rdner rdner commented Jun 27, 2023

What does this PR do?

So, we can avoid vulnerability reports from Snyk for the outdated images.

Why is it important?

Quite a few issues reported by Snyk have to do with the Docker images that we have for testing and development, so we should include them into updates to avoid extra reports from Snyk.

It's a follow up to #35919

So, we can avoid vulnerability reports from Snyk for the outdated images.
@rdner rdner added enhancement backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Jun 27, 2023
@rdner rdner self-assigned this Jun 27, 2023
@rdner rdner requested a review from a team as a code owner June 27, 2023 15:56
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label Team:Automation Label for the Observability productivity team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 27, 2023
@rdner rdner requested review from michalpristas and cmacknz June 27, 2023 15:57
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-27T15:57:01.669+0000

  • Duration: 13 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Collaborator

@pierrehilbert pierrehilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rdner rdner merged commit 3639b2e into elastic:main Jun 28, 2023
@rdner rdner deleted the update-golang-bump-job branch June 28, 2023 08:42
@v1v
Copy link
Member

v1v commented Jul 25, 2023

As a consequence of this change the updateCLI pipeline is not working:

update-version.asciidoc
-----------------------
✔ - all contents from 'file' and 'files' combined already up to date

ERROR: something went wrong in target "update-dockerfiles" : "no line matched in file \"./metricbeat/module/vsphere/_meta/Dockerfile\" for pattern \"FROM golang:\\\\d+.\\\\d+.\\\\d+\""

Pipeline "Bump golang-version to latest version" failed
Skipping due to:
	targets stage:	"something went wrong during target execution"

See this

Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
)

So, we can avoid vulnerability reports from Snyk for the outdated images.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify enhancement Team:Automation Label for the Observability productivity team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants