Make all docker images consistent for future updates #35919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have update CLI that takes care of Docker image updates. In order to cover all the images we need to make them consistent first. If we keep these images at older versions, we'll be constantly receiving CVE notifications, so it's easier to automate these updates even though these images are internal and are never released to the public.
rdner
added
enhancement
Team:Elastic-Agent-Data-Plane
botelastic
bot
added
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
rdner
added
backport-7.17
cmacknz
reviewed
Jun 27, 2023
| @@ -1,4 +1,4 @@ | |||
| FROM golang:alpine3.15 as builder | |||
There was a problem hiding this comment.
Alpine Linux isn't actually in our support matrix (https://www.elastic.co/support/matrix), so using Debian as the base image here makes more sense anyway.
cmacknz
approved these changes
Jun 27, 2023
ChrsMark
approved these changes
Jun 27, 2023
gizas
approved these changes
Jun 27, 2023
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
|
/test metricbeat-goIntegTest |
jlind23
approved these changes
Jun 27, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
We have update CLI that takes care of Docker image updates. In order to cover all the images we need to make them consistent first. If we keep these images at older versions, we'll be constantly receiving CVE notifications, so it's easier to automate these updates even though these images are internal and are never released to the public. (cherry picked from commit 27763e8) # Conflicts: # dev-tools/kubernetes/filebeat/Dockerfile.debug # dev-tools/kubernetes/heartbeat/Dockerfile.debug # dev-tools/kubernetes/metricbeat/Dockerfile.debug
mergify bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
We have update CLI that takes care of Docker image updates. In order to cover all the images we need to make them consistent first. If we keep these images at older versions, we'll be constantly receiving CVE notifications, so it's easier to automate these updates even though these images are internal and are never released to the public. (cherry picked from commit 27763e8)
rdner
added a commit
that referenced
this pull request
Jun 27, 2023
We have update CLI that takes care of Docker image updates. In order to cover all the images we need to make them consistent first. If we keep these images at older versions, we'll be constantly receiving CVE notifications, so it's easier to automate these updates even though these images are internal and are never released to the public. (cherry picked from commit 27763e8) Co-authored-by: Denis <[email protected]>
rdner
added a commit
that referenced
this pull request
Jun 28, 2023
…updates (#35929) * Make all docker images consistent for future updates (#35919) We have update CLI that takes care of Docker image updates. In order to cover all the images we need to make them consistent first. If we keep these images at older versions, we'll be constantly receiving CVE notifications, so it's easier to automate these updates even though these images are internal and are never released to the public. (cherry picked from commit 27763e8) # Conflicts: # dev-tools/kubernetes/filebeat/Dockerfile.debug # dev-tools/kubernetes/heartbeat/Dockerfile.debug # dev-tools/kubernetes/metricbeat/Dockerfile.debug * Delete files that are not present in 7.17 --------- Co-authored-by: Denis <[email protected]>
6 tasks
Scholar-Li
pushed a commit
to Scholar-Li/beats
that referenced
this pull request
Feb 5, 2024
We have update CLI that takes care of Docker image updates. In order to cover all the images we need to make them consistent first. If we keep these images at older versions, we'll be constantly receiving CVE notifications, so it's easier to automate these updates even though these images are internal and are never released to the public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We have update CLI that takes care of Docker image updates. In order to cover all the images we need to make them consistent first.
If we keep these images at older versions, we'll be constantly receiving CVE notifications, so it's easier to automate these updates even though these images are internal and are never released to the public.
Why is it important?
It's a preparation step for another PR that will come later and will update the update CLI configuration to include all these paths.
How to test this PR locally
I ran
docker build --no-cache .on each changed Dockerfile.