Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling IPv6 within square brackets (backport #32989) #33008

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 7, 2022

This is an automatic backport of pull request #32989 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* handling IPv6 within square brackets

(cherry picked from commit 05b4a42)
@mergify mergify bot requested a review from a team as a code owner September 7, 2022 13:14
@mergify mergify bot mentioned this pull request Sep 7, 2022
6 tasks
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 7, 2022
@gsantoro gsantoro added the Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team label Sep 7, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 7, 2022
@gsantoro gsantoro self-assigned this Sep 7, 2022
@gsantoro gsantoro added the bug label Sep 7, 2022
CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 7, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-07T13:26:36.164+0000

  • Duration: 72 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 6274
Skipped 737
Total 7011

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@andrewkroh
Copy link
Member

There will be no more releases from the 8.3 branch so there is no need to backport to 8.3. Only 8.4 will have new patch releases.

@gsantoro
Copy link
Contributor

gsantoro commented Sep 7, 2022

@andrewkroh I have been told differently. I'll send you some details about an internal discussion. I have been told by my tech lead to go forward

@gsantoro gsantoro merged commit 8927920 into 8.3 Sep 7, 2022
@gsantoro gsantoro deleted the mergify/bp/8.3/pr-32989 branch September 7, 2022 15:01
@cmacknz
Copy link
Member

cmacknz commented Sep 7, 2022

If you do revive the 8.3 branch, to fix the test failures you will need to backport 249d445 to 8.3 as well.

@gsantoro
Copy link
Contributor

gsantoro commented Sep 8, 2022

@cmacknz Sorry about breaking 8.3 building. I'll create a PR and cherry pick that commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants