-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handling IPv6 within square brackets #32989
handling IPv6 within square brackets #32989
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Relates: elastic/integrations#3117 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test data for the use case that this fixes. Add the samples to https://github.com/elastic/beats/blob/980972ea9a58bf6bb78fb190b499fbf9c17f1cc4/filebeat/module/nginx/ingress_controller/test/test.log then regenerate the expected.json file.
I was looking into adding some tests but currently I can't find how to run those ingest pipeilne tests in the nginx_ingress_controller fileset. Is there something like what we use in the integrations repo (eg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@Mergifyio backport 8.3 |
✅ Backports have been created
|
* handling IPv6 within square brackets (cherry picked from commit 05b4a42)
@Mergifyio backport 7.17 |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
@gsantoro is it possible to backport this into 7.17 branch? |
* handling IPv6 within square brackets
What does this PR do?
Handle [] around IPv6 in upstream servers addresses
Why is it important?
If upstream server field has an IPv6 it will not be correctly handled.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
cd filebeat GENERATE=true TESTING_FILEBEAT_MODULES=nginx TESTING_FILEBEAT_FILESETS=ingress_controller mage -v pythonIntegTest
How to test this PR locally
Related issues