action: checks for winlogbeat and x-pack/winlogbeat #32750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
added
automation
Team:Automation
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
andrewkroh
reviewed
Aug 22, 2022
efd6
reviewed
Aug 22, 2022
use v3 and avoid latest in favour of go.sum
andrewkroh
approved these changes
Aug 23, 2022
andrewkroh
reviewed
Aug 23, 2022
mergify bot
pushed a commit
that referenced
this pull request
Aug 24, 2022
(cherry picked from commit 4f80e0f) # Conflicts: # .github/workflows/opentelemetry.yml # winlogbeat/Jenkinsfile.yml # x-pack/winlogbeat/Jenkinsfile.yml
mergify bot
pushed a commit
that referenced
this pull request
Aug 24, 2022
(cherry picked from commit 4f80e0f) # Conflicts: # .github/workflows/opentelemetry.yml
v1v
pushed a commit
that referenced
this pull request
Aug 25, 2022
v1v
pushed a commit
that referenced
this pull request
Aug 25, 2022
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use GitHub actions to run the
check stageforwinlogbeatandx-pack/winlogbeatWhat's the
check stage?make checkmake updatemake check-no-changesmage checkmage updateWhy is it important?
Faster builds by running linting/checks outside of the main CI Pipeline.
Errors
Further details
The existing checks in Jenkins are replaced with GitHub checks, hence the union of these 2 new Github workflows substitutes each former check. Therefore, the same commands will run for the same scenarios.
Results
Nearly 10 minutes since they build was triggered in Jenkins and still waiting for workers to be assigned, while the new GitHub checks finished relatively much faster
Related issues
Similar to #32711