-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
actions: run check for x-pack/packetbeat and packebeat #32711
Conversation
This pull request does not have a backport label.
|
- '.github/workflows/check-packetbeat.yml' | ||
- 'packetbeat/**' | ||
- 'x-pack/packetbeat/**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When changes in those files
export PATH=$PATH:$(go env GOPATH)/bin | ||
go install github.com/magefile/mage@latest | ||
make -C ${{ env.BEAT_MODULE }} check update | ||
make check-no-changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then run make
- '.github/workflows/check-xpack-packetbeat.yml' | ||
- 'x-pack/packetbeat/**' | ||
- 'packetbeat/**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When changes in these files
(cherry picked from commit 54b6f15) # Conflicts: # packetbeat/Jenkinsfile.yml # x-pack/packetbeat/Jenkinsfile.yml
(cherry picked from commit 54b6f15)
(cherry picked from commit 54b6f15) Co-authored-by: Victor Martinez <[email protected]>
What does this PR do?
Use GitHub actions to run the
check stage
forpacketbeat
andx-pack/packetbeat
What's the
check stage
?make check
make update
make check-no-changes
mage check
mage update
Why is it important?
Faster build by running linting/checks outside of the main CI Pipeline.
Further details
The existing checks in Jenkins are replaced with GitHub checks, hence the union of these 2 new Github workflows substitutes each former check. Therefore, the same commands will run for the same scenarios.
Solved Issues
pcap.h: No such file or directory
Solved with a315907
Results
Nearly 10 minutes since they build was triggered in Jenkins and still waiting for workers to be assigned, while the new GitHub checks finished relatively much faster
Follow ups
If agreed then we can roll out this approach for the remaining beats