-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filebeat: Apache2 module #3256
Filebeat: Apache2 module #3256
Conversation
@@ -0,0 +1,9 @@ | |||
- key: apache2 | |||
title: "apache2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably capitalise all titles. We could do this also in the script. @dedemorton did for this some cleanup in Metricbeat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is created by the generator, which is somehow limited in that regard. Do you mean fixing it up by hand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed it by hand.
example: Chrome | ||
description: > | ||
The name of the user agent. | ||
- name: os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
os.name, os.major, os.minor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are created by the user agent processor, which is not that flexible when it comes to field names: https://www.elastic.co/guide/en/elasticsearch/plugins/master/using-ingest-user-agent.html
We could maybe do renamings, but I'd say the complexity is not worth it.
- name: os_name | ||
type: keyword | ||
description: > | ||
The name of the operating system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this different from os
?
"user_agent": { | ||
"major": "50", | ||
"minor": "0", | ||
"os": "Mac OS X 10.12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, os
contains all info and the other 3 are a split up version. Do we need the split up version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's what the processor does by default. I'd stick with that, since if we don't, someone will ask why it's different from LS.
6147859
to
c1e321f
Compare
Contains: * access logs fileset, with with_plugins and no_plugins versions * error logs fileset * Kibana dashboards
c1e321f
to
0c5d820
Compare
@ruflin rebased and squashed. |
jenkins, package it |
jenkins, test it |
Contains filesets for access logs and error logs. It's similar with the Nginx one, although coming with a few challenges of its own.
Sample dashboard:
Will need a rebase on top #3248. Part of #3159.