Generator for a Filebeat module/fileset #3248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the model of the Metricbeat module generator, this creates templates for most of the required files of a fileset, making it easier to get started. To use, run as: MODULE=apache FILESET=access make create-fileset The PR includes some minor cleanups to the Metricbeat version. Part of elastic#3159.
This was referenced Dec 26, 2016
ruflin
approved these changes
Jan 2, 2017
| @@ -12,14 +12,14 @@ def generate_metricset(base_path, metricbeat_path, module, metricset): | |||
| meta_path = metricset_path + "/_meta" | |||
|
|
|||
| if os.path.isdir(metricset_path): | |||
| print "MericSet already exists. Skipping creating metricset " + metricset + ".\n" | |||
| print("Metricset already exists. Skipping creating metricset {}" | |||
There was a problem hiding this comment.
Will this still print a newline?
|
Merged already. We can still do some improvements later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the model of the Metricbeat module generator, this creates
templates for most of the required files of a fileset, making it
easier to get started.
To use, run as:
The PR includes some minor cleanups to the Metricbeat version.
Part of #3159.