Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linters: remove godox and add exclude rule for forbidigo in mage files #31433

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Linters: remove godox and add exclude rule for forbidigo in mage files #31433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ issues:
- linters:
- stylecheck
text: "ST1003:"
# From mage we are priting to the console to ourselves
- path: (.*magefile.go|.*dev-tools/mage/.*)
linters: forbidigo

output:
sort-results: true
Expand Down Expand Up @@ -68,7 +71,6 @@ linters:
- noctx # noctx finds sending http request without context.Context
- unconvert # Remove unnecessary type conversions
- wastedassign # wastedassign finds wasted assignment statements.
- godox # tool for detection of FIXME, TODO and other comment keywords
- gomodguard # check for blocked dependencies

# all available settings of specific linters
Expand Down
4 changes: 3 additions & 1 deletion dev-tools/templates/.golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ issues:
- text: "ST1003:"
linters:
- stylecheck
# From mage we are priting to the console to ourselves
- path: (.*magefile.go|.*dev-tools/mage/.*)
linters: forbidigo

output:
sort-results: true
Expand Down Expand Up @@ -65,7 +68,6 @@ linters:
- noctx # noctx finds sending http request without context.Context
- unconvert # Remove unnecessary type conversions
- wastedassign # wastedassign finds wasted assignment statements.
- godox # tool for detection of FIXME, TODO and other comment keywords
- gomodguard # check for blocked dependencies

# all available settings of specific linters
Expand Down