Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heartbeat: fix browser metrics and trace mappings #30258

Merged
merged 3 commits into from
Feb 16, 2022

Conversation

vigneshshanmugam
Copy link
Member

@vigneshshanmugam vigneshshanmugam added bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team backport-v8.0.0 Automated backport with mergify v8.1.0 backport-v8.1.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify labels Feb 8, 2022
@vigneshshanmugam vigneshshanmugam requested a review from a team as a code owner February 8, 2022 04:22
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 8, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 8, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-15T16:15:55.079+0000

  • Duration: 79 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 2610
Skipped 49
Total 2659

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Feb 11, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b update-synth-mapping upstream/update-synth-mapping
git merge upstream/main
git push upstream update-synth-mapping

Copy link
Contributor

@lucasfcosta lucasfcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have E2E tested this and compared these changes to the mappings for the synthetics integration. It LGTM.

My E2E test consisted of:

  1. Creating a Heartbeat config file with browser monitors
  2. Checking out this branch and running mage build
  3. Running the built Heartbeat against my local ES
  4. Checking the documents sent on the Kibana Dev Console
    GET /.ds-heartbeat-8.2.0-2022.02.15-000001/_search
    {
      "size": 50, 
      "query": {
        "match": {
          "event.type": "step/metrics"
        }
      }
    }
    
  5. Checking the mappings themselves in the index management screen
    Screenshot 2022-02-15 at 19 04 31
  6. Making sure the monitors themselves work fine (including the waterfall chart)
    Screenshot 2022-02-15 at 19 05 16

I'd appreciate it if @dominiqueclarke could just confirm these look OK on her side too, but no need to E2E test I'd say.

@vigneshshanmugam vigneshshanmugam merged commit f535d19 into elastic:main Feb 16, 2022
mergify bot pushed a commit that referenced this pull request Feb 16, 2022
* Heartbeat: fix browser metrics and trace mappings

* update fields

(cherry picked from commit f535d19)

# Conflicts:
#	heartbeat/include/fields.go
#	x-pack/heartbeat/include/fields.go
mergify bot pushed a commit that referenced this pull request Feb 16, 2022
* Heartbeat: fix browser metrics and trace mappings

* update fields

(cherry picked from commit f535d19)
mergify bot pushed a commit that referenced this pull request Feb 16, 2022
* Heartbeat: fix browser metrics and trace mappings

* update fields

(cherry picked from commit f535d19)
vigneshshanmugam added a commit that referenced this pull request Feb 16, 2022
* Heartbeat: fix browser metrics and trace mappings

* update fields

(cherry picked from commit f535d19)

Co-authored-by: Vignesh Shanmugam <[email protected]>
vigneshshanmugam added a commit that referenced this pull request Feb 16, 2022
* Heartbeat: fix browser metrics and trace mappings

* update fields

(cherry picked from commit f535d19)

Co-authored-by: Vignesh Shanmugam <[email protected]>
vigneshshanmugam added a commit that referenced this pull request Feb 16, 2022
…ings (#30416)

* Heartbeat: fix browser metrics and trace mappings (#30258)

* Heartbeat: fix browser metrics and trace mappings

* update fields

(cherry picked from commit f535d19)

# Conflicts:
#	heartbeat/include/fields.go
#	x-pack/heartbeat/include/fields.go

* update fields

Co-authored-by: Vignesh Shanmugam <[email protected]>
v1v added a commit to v1v/beats that referenced this pull request Feb 21, 2022
…into feature/use-with-kind-k8s-env

* 'feature/use-with-kind-k8s-env' of github.com:v1v/beats: (52 commits)
  ci: home is declared within withBeatsEnv
  ci: use withKindEnv step
  ci: use getBranchesFromAliases and support next-patch-8 (elastic#30400)
  Update fields.yml (elastic#29609)
  Heartbeat: fix browser metrics and trace mappings (elastic#30258)
  Apply light edits to 8.0 changelog (elastic#30351)
  packetbeat/beater: make sure Npcap installation runs before interfaces are needed (elastic#30396)
  Add a ring-buffer reporter to libbeat (elastic#28750)
  Osquerybeat: Add install verification for osquerybeat (elastic#30388)
  update windows matrix support (elastic#30373)
  Refactor of metricbeat process-gathering metrics and system/process (elastic#30076)
  adjust next changelog wording (elastic#30371)
  [Metricbeat] azure: move event report into loop validDim loop (elastic#29945)
  fix: report GitHub Check before the cache (elastic#30372)
  Add support for non-unique keys in Kafka output headers (elastic#30369)
  ci: 6 major branch reached EOL (elastic#30357)
  reduce Elastic Agent shut down time by stopping processes concurrently (elastic#29650)
  [Filebeat] Add message to register encode/decode debug logs (elastic#30271)
  [libbeat] kafka message header support (elastic#29940)
  Heartbeat: set duration to zero for syntax errors (elastic#30227)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Heartbeat] Move browser fields to root
3 participants