-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heartbeat: fix browser metrics and trace mappings #30258
Heartbeat: fix browser metrics and trace mappings #30258
Conversation
Pinging @elastic/uptime (Team:Uptime) |
This pull request is now in conflicts. Could you fix it? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have E2E tested this and compared these changes to the mappings for the synthetics integration. It LGTM.
My E2E test consisted of:
- Creating a Heartbeat config file with browser monitors
- Checking out this branch and running
mage build
- Running the built Heartbeat against my local ES
- Checking the documents sent on the Kibana Dev Console
GET /.ds-heartbeat-8.2.0-2022.02.15-000001/_search { "size": 50, "query": { "match": { "event.type": "step/metrics" } } }
- Checking the mappings themselves in the index management screen
- Making sure the monitors themselves work fine (including the waterfall chart)
I'd appreciate it if @dominiqueclarke could just confirm these look OK on her side too, but no need to E2E test I'd say.
* Heartbeat: fix browser metrics and trace mappings * update fields (cherry picked from commit f535d19) # Conflicts: # heartbeat/include/fields.go # x-pack/heartbeat/include/fields.go
* Heartbeat: fix browser metrics and trace mappings * update fields (cherry picked from commit f535d19)
* Heartbeat: fix browser metrics and trace mappings * update fields (cherry picked from commit f535d19)
* Heartbeat: fix browser metrics and trace mappings * update fields (cherry picked from commit f535d19) Co-authored-by: Vignesh Shanmugam <[email protected]>
* Heartbeat: fix browser metrics and trace mappings * update fields (cherry picked from commit f535d19) Co-authored-by: Vignesh Shanmugam <[email protected]>
…ings (#30416) * Heartbeat: fix browser metrics and trace mappings (#30258) * Heartbeat: fix browser metrics and trace mappings * update fields (cherry picked from commit f535d19) # Conflicts: # heartbeat/include/fields.go # x-pack/heartbeat/include/fields.go * update fields Co-authored-by: Vignesh Shanmugam <[email protected]>
…into feature/use-with-kind-k8s-env * 'feature/use-with-kind-k8s-env' of github.com:v1v/beats: (52 commits) ci: home is declared within withBeatsEnv ci: use withKindEnv step ci: use getBranchesFromAliases and support next-patch-8 (elastic#30400) Update fields.yml (elastic#29609) Heartbeat: fix browser metrics and trace mappings (elastic#30258) Apply light edits to 8.0 changelog (elastic#30351) packetbeat/beater: make sure Npcap installation runs before interfaces are needed (elastic#30396) Add a ring-buffer reporter to libbeat (elastic#28750) Osquerybeat: Add install verification for osquerybeat (elastic#30388) update windows matrix support (elastic#30373) Refactor of metricbeat process-gathering metrics and system/process (elastic#30076) adjust next changelog wording (elastic#30371) [Metricbeat] azure: move event report into loop validDim loop (elastic#29945) fix: report GitHub Check before the cache (elastic#30372) Add support for non-unique keys in Kafka output headers (elastic#30369) ci: 6 major branch reached EOL (elastic#30357) reduce Elastic Agent shut down time by stopping processes concurrently (elastic#29650) [Filebeat] Add message to register encode/decode debug logs (elastic#30271) [libbeat] kafka message header support (elastic#29940) Heartbeat: set duration to zero for syntax errors (elastic#30227) ...
browser.experience
andbrowser.relative_trace
to the root HB mapping fields.