-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heartbeat: set duration to zero for syntax errors #30227
Heartbeat: set duration to zero for syntax errors #30227
Conversation
Pinging @elastic/uptime (Team:Uptime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (also verified the behavior works well on kibana)
Discussed in Tech Sync to consider having this as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Heartbeat: set duration to 0 for syntax errors * set duration to null (cherry picked from commit 06c810c)
* Heartbeat: set duration to 0 for syntax errors * set duration to null (cherry picked from commit 06c810c)
* Heartbeat: set duration to 0 for syntax errors * set duration to null (cherry picked from commit 06c810c)
* Heartbeat: set duration to 0 for syntax errors * set duration to null (cherry picked from commit 06c810c) Co-authored-by: Vignesh Shanmugam <[email protected]>
* Heartbeat: set duration to 0 for syntax errors * set duration to null (cherry picked from commit 06c810c) Co-authored-by: Vignesh Shanmugam <[email protected]>
* Heartbeat: set duration to 0 for syntax errors * set duration to null (cherry picked from commit 06c810c) Co-authored-by: Vignesh Shanmugam <[email protected]>
…into feature/use-with-kind-k8s-env * 'feature/use-with-kind-k8s-env' of github.com:v1v/beats: (52 commits) ci: home is declared within withBeatsEnv ci: use withKindEnv step ci: use getBranchesFromAliases and support next-patch-8 (elastic#30400) Update fields.yml (elastic#29609) Heartbeat: fix browser metrics and trace mappings (elastic#30258) Apply light edits to 8.0 changelog (elastic#30351) packetbeat/beater: make sure Npcap installation runs before interfaces are needed (elastic#30396) Add a ring-buffer reporter to libbeat (elastic#28750) Osquerybeat: Add install verification for osquerybeat (elastic#30388) update windows matrix support (elastic#30373) Refactor of metricbeat process-gathering metrics and system/process (elastic#30076) adjust next changelog wording (elastic#30371) [Metricbeat] azure: move event report into loop validDim loop (elastic#29945) fix: report GitHub Check before the cache (elastic#30372) Add support for non-unique keys in Kafka output headers (elastic#30369) ci: 6 major branch reached EOL (elastic#30357) reduce Elastic Agent shut down time by stopping processes concurrently (elastic#29650) [Filebeat] Add message to register encode/decode debug logs (elastic#30271) [libbeat] kafka message header support (elastic#29940) Heartbeat: set duration to zero for syntax errors (elastic#30227) ...
journey/start
never fires as the Synthetics runner cannot register the journeys and node runs to completion with exit status 1.0
instead of setting false positive values.