Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove macOS preference panels and code related to DMG #30097

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Remove macOS preference panels and code related to DMG #30097

merged 1 commit into from
Feb 2, 2022

Conversation

ph
Copy link
Contributor

@ph ph commented Jan 28, 2022

This commit removes the build of the macOS preference panels for Filebeat,
Auditbeat, Metricbeat, heartbeat. This artifact was never released
officially and was unsupported. We do not have any tests in place to
assert that the new version of macOS doesn't break the preference panel.

Remove the code related to building DMG images, this was only required
to package the preference panel.

Fixes: #30003

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
    -[ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ph
Remove macOS preference panels and code related to DMG
e49ba9f 
This commit removes the build of the macOS preference panels for Filebeat,
Auditbeat, Metricbeat, heartbeat. This artifact was never released
officially and was unsupported. We do not have any tests in places to
assert that new version of macOS doesn't break the preference panel.

Remove the code related to building DMG images, this was only required
to package the preference panel.

Fixes: elastic#30003
@ph ph added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jan 28, 2022
@ph ph self-assigned this Jan 28, 2022
@ph ph requested review from a team as code owners January 28, 2022 22:07
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 28, 2022
@ph
Copy link
Contributor Author

ph commented Jan 28, 2022

/package

@mergify
Copy link
Contributor

mergify bot commented Jan 28, 2022

This pull request does not have a backport label. Could you fix it @ph? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 28, 2022
@ph ph requested a review from narph January 28, 2022 22:07
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-01-28T22:07:41.955+0000

  • Duration: 272 min 7 sec

  • Commit: e49ba9f

Test stats 🧪

Test Results
Failed 0
Passed 47981
Skipped 4292
Total 52273

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

narph
narph approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@narph narph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ph ph merged commit c87406b into elastic:master Feb 2, 2022
@ph ph deleted the fix/remove-macos-pref branch February 2, 2022 21:15
axw added a commit to axw/apm-server that referenced this pull request Feb 7, 2022
@axw
magefile: remove DMG-related bits
cb09936 
Removed from libbeat in elastic/beats#30097
@axw axw mentioned this pull request Feb 7, 2022
Merged
axw added a commit to axw/apm-server that referenced this pull request Feb 7, 2022
@axw
magefile: remove DMG-related bits
4c1e2b5 
Removed from libbeat in elastic/beats#30097
@axw axw mentioned this pull request Feb 7, 2022
Merged
axw added a commit to elastic/apm-server that referenced this pull request Feb 7, 2022
@axw
Update to elastic/beats@e675f4e (#7213)
c4cd6c4 
* magefile: remove DMG-related bits

Removed from libbeat in elastic/beats#30097

* Update to elastic/beats@e675f4e82c7a
axw added a commit to elastic/apm-server that referenced this pull request Feb 7, 2022
@axw
Update to elastic/beats@ba6d176 (#7212)
b24a9ec 
* Update to elastic/beats@ba6d1768469a

* magefile: remove DMG-related bits

Removed from libbeat in elastic/beats#30097
@graphaelli graphaelli mentioned this pull request Feb 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narph narph narph approved these changes

@AndersonQ AndersonQ AndersonQ approved these changes

Assignees

@ph ph

Labels
backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Beats] Simplify build by removing macOS preference pannel.
4 participants
@ph @elasticmachine @AndersonQ @narph