Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Beats] Simplify build by removing macOS preference pannel. #30003

Closed
ph opened this issue Jan 25, 2022 · 3 comments · Fixed by #30097
Closed

[Beats] Simplify build by removing macOS preference pannel. #30003

ph opened this issue Jan 25, 2022 · 3 comments · Fixed by #30097
Assignees
@ph
Labels
8.3-candidate cleanup Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team technical debt

Comments

@ph
Copy link
Contributor

ph commented Jan 25, 2022

We have jobs and code to build macOS preference panel in beats for all of our beats. AFAIK we never released them officially for any beats, I am not even sure they are still working with the latest macOS. They are currently unmaintained by any teams and add complexity to the build process.

With the refactoring of the beats repository into smallers repositories and the move to Elastic Agent, I believe we should remove them.
@ph ph added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jan 25, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@ph
Copy link
Contributor Author

ph commented Jan 25, 2022

@narph @jlind23 FYI, Opportunity to reduce the burden of moving stuff.

@ph
Copy link
Contributor Author

ph commented Jan 25, 2022

@andrewkroh @adriansr If I remember correctly this was done a few years ago, do you agree with me to remove them?

@ph ph self-assigned this Jan 28, 2022
ph added a commit to ph/beats that referenced this issue Jan 28, 2022
@ph
Remove macOS preference panels and code related to DMG
e49ba9f 
This commit removes the build of the macOS preference panels for Filebeat,
Auditbeat, Metricbeat, heartbeat. This artifact was never released
officially and was unsupported. We do not have any tests in places to
assert that new version of macOS doesn't break the preference panel.

Remove the code related to building DMG images, this was only required
to package the preference panel.

Fixes: elastic#30003
@ph ph mentioned this issue Jan 28, 2022
Merged
1 task
@ph ph closed this as completed in #30097 Feb 2, 2022
ph added a commit that referenced this issue Feb 2, 2022
@ph
Remove macOS preference panels and code related to DMG (#30097)
c87406b 
This commit removes the build of the macOS preference panels for Filebeat,
Auditbeat, Metricbeat, heartbeat. This artifact was never released
officially and was unsupported. We do not have any tests in place to
assert that the new version of macOS doesn't break the preference panel.

Remove the code related to building DMG images, this was only required
to package the preference panel.

Fixes: #30003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ph ph

Labels
8.3-candidate cleanup Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove macOS preference panels and code related to DMG ph/beats
3 participants
@ph @elasticmachine @jlind23