Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: simplify permissions for Dockerfile COPY #27754

Merged
merged 1 commit into from
Sep 8, 2021
Merged

docs: simplify permissions for Dockerfile COPY #27754

merged 1 commit into from
Sep 8, 2021

Conversation

mshavliuk
Copy link
Contributor

@mshavliuk mshavliuk commented Sep 4, 2021 •
edited
Loading

  • Docs

What does this PR do?

Simplify the file permission change in referenced Dockerfile by using COPY --chown argument.
See the Dockerfile documentation: https://docs.docker.com/engine/reference/builder/#copy

Why is it important?

The one-step file copy with the right permissions allows to reduce the number of layers in resulting docker image and simplifies the code. See also the article explaining how the multi-step COPY + chown doubles the image size: https://blog.mornati.net/docker-images-and-files-chown

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 4, 2021
@cla-checker-service
Copy link

cla-checker-service bot commented Sep 4, 2021 •
edited
Loading

💚 CLA has been signed

@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 4, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-08T12:27:50.414+0000

  • Duration: 27 min 41 sec

  • Commit: 330c0a0

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

@ChrsMark ChrsMark added the Team:Integrations Label for the Integrations team label Sep 8, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 8, 2021
@ChrsMark
Copy link
Member

ChrsMark commented Sep 8, 2021

@MichaelKatsoulis do you mind reviewing this?

@MichaelKatsoulis
Copy link
Contributor

/test

@MichaelKatsoulis
Copy link
Contributor

@mshavliuk thank you for contributing. You should open this PR on beats master branch and it will be part of upcoming 7.16 release.

@mshavliuk mshavliuk changed the base branch from 7.14 to master September 8, 2021 09:58
@mshavliuk mshavliuk requested review from a team as code owners September 8, 2021 09:58
@mshavliuk
Copy link
Contributor Author

mshavliuk commented Sep 8, 2021 •
edited
Loading

You should open this PR on beats master branch

DONE

@v1v v1v removed the request for review from a team September 8, 2021 10:27
@MichaelKatsoulis
Copy link
Contributor

/test

@MichaelKatsoulis MichaelKatsoulis added the backport-v7.16.0 Automated backport with mergify label Sep 8, 2021
@MichaelKatsoulis MichaelKatsoulis self-requested a review September 8, 2021 13:23
MichaelKatsoulis
MichaelKatsoulis approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@MichaelKatsoulis MichaelKatsoulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @mshavliuk

@MichaelKatsoulis MichaelKatsoulis merged commit 5fe61ca into elastic:master Sep 8, 2021
mergify bot pushed a commit that referenced this pull request Sep 8, 2021
@mshavliuk
docs: simplify permissions for Dockerfile COPY (#27754)
593ce81 
ref: https://docs.docker.com/engine/reference/builder/#copy
(cherry picked from commit 5fe61ca)
@mergify mergify bot mentioned this pull request Sep 8, 2021
Merged
@mshavliuk mshavliuk deleted the patch-1 branch September 8, 2021 13:43
MichaelKatsoulis pushed a commit that referenced this pull request Sep 8, 2021
@mergify @mshavliuk
docs: simplify permissions for Dockerfile COPY (#27754) (#27809)
3f12525 
ref: https://docs.docker.com/engine/reference/builder/#copy
(cherry picked from commit 5fe61ca)

Co-authored-by: Mikhail <[email protected]>
mdelapenya added a commit to mdelapenya/beats that referenced this pull request Sep 9, 2021
@mdelapenya
Merge branch 'master' into 27608-fix-elastic-agent-build
16ae989 
* master: (39 commits)
  [Heartbeat] Move JSON tests from python->go (elastic#27816)
  docs: simplify permissions for Dockerfile COPY (elastic#27754)
  Osquerybeat: Fix osquery logger plugin severy levels mapping (elastic#27789)
  [Filebeat] Update compatibility function to remove processor description on ES < 7.9.0 (elastic#27774)
  warn log entry and no validation failure when both queue_url and buck… (elastic#27612)
  libbeat/cmd/instance: ensure test config file has appropriate permissions (elastic#27178)
  [Heartbeat] Add httpcommon options to ZipURL (elastic#27699)
  Add a header round tripper option to httpcommon (elastic#27509)
  [Elastic Agent] Add validation to ensure certificate paths are absolute. (elastic#27779)
  Rename dashboards according to module.yml files for master (elastic#27749)
  Refactor vagrantfile, add scripts for provisioning with docker/kind (elastic#27726)
  Accept syslog dates with leading 0 (elastic#27775)
  [Filebeat] Add timezone config option to decode_cef and syslog input (elastic#27727)
  [Filebeat] Threatintel compatibility updates (elastic#27323)
  Add support for ephemeral containers in elastic agent dynamic provider (elastic#27707)
  [Filebeat] Integration tests in CI for AWS-S3 input (elastic#27491)
  Fix flakyness of TestFilestreamEmptyLine (elastic#27705)
  [Filebeat] kafka v2 using parsers (elastic#27335)
  Update Kafka version parsing / supported range (elastic#27720)
  Update Sarama to 1.29.1 (elastic#27717)
  ...
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
@mshavliuk
docs: simplify permissions for Dockerfile COPY (elastic#27754)
fdd2147 
ref: https://docs.docker.com/engine/reference/builder/#copy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelKatsoulis MichaelKatsoulis MichaelKatsoulis approved these changes

Assignees
No one assigned
Labels
backport-v7.16.0 Automated backport with mergify Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mshavliuk @elasticmachine @ChrsMark @MichaelKatsoulis