Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #24829 to 7.13: [Filebeat] Update Oauth2 flow for m365 defender fileset #25227

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Cherry-pick #24829 to 7.13: [Filebeat] Update Oauth2 flow for m365 defender fileset #25227

merged 1 commit into from
Apr 23, 2021

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Apr 22, 2021 •
edited by zube bot
Loading

Cherry-pick of PR #24829 to 7.13 branch. Original message:

What does this PR do?

Microsoft changed the Oauth2 flow from resource to scope based, so the default configuration and documentation needs to reflect that.

Why is it important?

Module won't work without it.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@P1llus
[Filebeat] Update Oauth2 flow for m365 defender fileset (elastic#24829)
19de936 
* updating m365 config and documentation to match new Oauth2 authentication flow

* Update changelog

(cherry picked from commit 55be313)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 22, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 22, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 22, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: P1llus commented: jenkins run tests

  • Start Time: 2021-04-23T19:15:28.586+0000

  • Duration: 52 min 15 sec

  • Commit: 19de936

Test stats 🧪

Test Results
Failed 0
Passed 3910
Skipped 315
Total 4225

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 3910
Skipped 315
Total 4225

@P1llus
Copy link
Member Author

P1llus commented Apr 23, 2021

jenkins run tests

@P1llus P1llus merged commit 39849e2 into elastic:7.13 Apr 23, 2021
@zube zube bot removed the [zube]: Done label Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@P1llus @elasticmachine