Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Update Oauth2 flow for m365 defender fileset #24829

Merged
merged 2 commits into from
Mar 30, 2021

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Mar 30, 2021

What does this PR do?

Microsoft changed the Oauth2 flow from resource to scope based, so the default configuration and documentation needs to reflect that.

Why is it important?

Module won't work without it.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 30, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 30, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: P1llus commented: jenkins run tests

  • Start Time: 2021-03-30T12:38:44.109+0000

  • Duration: 54 min 24 sec

  • Commit: 2c54da1

Test stats 🧪

Test Results
Failed 0
Passed 13193
Skipped 2271
Total 15464

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 13193
Skipped 2271
Total 15464

@P1llus
Copy link
Member Author

P1llus commented Mar 30, 2021

jenkins run tests

@P1llus P1llus merged commit 55be313 into elastic:master Mar 30, 2021
P1llus added a commit to P1llus/beats that referenced this pull request Mar 30, 2021
* updating m365 config and documentation to match new Oauth2 authentication flow

* Update changelog

(cherry picked from commit 55be313)
@P1llus P1llus added the v7.12.0 label Mar 30, 2021
P1llus added a commit to P1llus/beats that referenced this pull request Mar 30, 2021
* updating m365 config and documentation to match new Oauth2 authentication flow

* Update changelog

(cherry picked from commit 55be313)
@P1llus P1llus added the v7.12.1 label Mar 30, 2021
P1llus added a commit to P1llus/beats that referenced this pull request Mar 30, 2021
* updating m365 config and documentation to match new Oauth2 authentication flow

* Update changelog

(cherry picked from commit 55be313)
P1llus added a commit to P1llus/beats that referenced this pull request Mar 30, 2021
* updating m365 config and documentation to match new Oauth2 authentication flow

* Update changelog

(cherry picked from commit 55be313)
@marc-gr marc-gr added needs_integration_sync Changes in this PR need synced to elastic/integrations. and removed needs_integration_sync Changes in this PR need synced to elastic/integrations. labels Apr 22, 2021
@P1llus P1llus added the v7.13.0 label Apr 22, 2021
P1llus added a commit to P1llus/beats that referenced this pull request Apr 22, 2021
* updating m365 config and documentation to match new Oauth2 authentication flow

* Update changelog

(cherry picked from commit 55be313)
P1llus added a commit to P1llus/beats that referenced this pull request Apr 22, 2021
* updating m365 config and documentation to match new Oauth2 authentication flow

* Update changelog

(cherry picked from commit 55be313)
P1llus added a commit that referenced this pull request Apr 22, 2021
…ender fileset (#25228)

* [Filebeat] Update Oauth2 flow for m365 defender fileset (#24829)

* updating m365 config and documentation to match new Oauth2 authentication flow

* Update changelog

(cherry picked from commit 55be313)

* Update CHANGELOG.next.asciidoc
P1llus added a commit that referenced this pull request Apr 23, 2021
)

* updating m365 config and documentation to match new Oauth2 authentication flow

* Update changelog

(cherry picked from commit 55be313)
@P1llus P1llus added the needs_integration_sync Changes in this PR need synced to elastic/integrations. label May 18, 2021
@eduardoarreolabt
Copy link

eduardoarreolabt commented Aug 11, 2021

I experienced the same permission error on Filebeat v.7.11 and have upgraded to version 7.14 but received a different error message
Filebeat error

@eduardoarreolabt
Copy link

recently updated the var.oauth2.token_url in the Microsoft defender_atp module and the error is regarding "oauth2: cannot fetch token: 400 Bad Request"
Filebeat error (2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Filebeat Filebeat needs_integration_sync Changes in this PR need synced to elastic/integrations. v7.12.0 v7.12.1 v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants