-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cloud.service.name to add_cloud_metadata #24993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. For quick reference this PR uses these values:
Provider | cloud.service.name |
---|---|
Alibaba | ECS |
AWS | EC2 |
Azure | Virtual Machines |
Digital Ocean | Droplets |
GCE | |
OpenStack | Nova |
Tencent | CVM |
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
* Add cloud.service.name to add_cloud_metadata * update changelog (cherry picked from commit 5bde9d0)
* Add cloud.service.name to add_cloud_metadata * update changelog (cherry picked from commit 5bde9d0) Co-authored-by: Andrew Stucki <[email protected]>
* upstream/master: (308 commits) [winlogbeat] Add support for sysmon v13 events 24 and 25 (elastic#24945) mergify: add backport label (elastic#25050) Add pod.ip in k8s metadata (elastic#25037) [elastic-agent] Use fleet.url for container cmd (elastic#25026) disable TestXPackEnabled flaky test in logstash metricbeat module (elastic#25034) Leverege leader election in agent k8s manifests (elastic#25016) libbeat/publisher/pipeline: expand monitoring (elastic#24700) libbeat: fix decode_json_fields config validation (elastic#24862) Remove make docs-preview instructions (elastic#25001) [Filebeat] Fix IPtables pipeline (elastic#24928) [DOCS] cd into correct directory before invoking mage. (elastic#17679) Add -buildmode=pie for supported platform (elastic#24964) Add agent's direcotry in k8s manifest generator (elastic#24987) [mergify] assign the original author (elastic#25007) Fix AWS module flaky tests (elastic#24852) [filebeat] Use fail_on_template_error on google_workspace and okta pagination (elastic#24967) Updated config to match defaults (elastic#25004) [Filebeat] Fix hardcoded amazonaws.com endpoint (elastic#24861) Add cloud.service.name to add_cloud_metadata (elastic#24993) [Ingest Manager] Expose processes and their metrics (elastic#24788) ...
What does this PR do?
This adds the new ECS 1.9 field
cloud.service.name
toadd_cloud_metadata
.I tried to use the names of each service we're retrieving metadata for as it exists in the majority of the literature. In some cases this means this uses shorthand names (i.e.
EC2
) and, when shorthand isn't commonly in the cloud provider's docs (i.e. AWS), the full name is used (i.e.Virtual Machines
).Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.