Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AWS module flaky tests #24852

Merged
merged 5 commits into from
Apr 12, 2021
Merged

Fix AWS module flaky tests #24852

merged 5 commits into from
Apr 12, 2021

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Mar 30, 2021

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 30, 2021
@kaiyan-sheng kaiyan-sheng self-assigned this Mar 30, 2021
@kaiyan-sheng kaiyan-sheng added the Team:Integrations Label for the Integrations team label Mar 30, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 30, 2021
@ChrsMark
Copy link
Member

It looks good! Thanks. Just one question: I wonder if we can define a dynamic mapping for aws.*.metrics.*.* like what we do for prometheus metrics, would it be possible (not in this PR)?

@kaiyan-sheng
Copy link
Contributor Author

/test

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 31, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24852 updated

  • Start Time: 2021-04-08T09:40:51.638+0000

  • Duration: 166 min 18 sec

  • Commit: bd7784b

Test stats 🧪

Test Results
Failed 0
Passed 9905
Skipped 2601
Total 12506

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 9905
Skipped 2601
Total 12506

@kaiyan-sheng
Copy link
Contributor Author

/test

@kaiyan-sheng
Copy link
Contributor Author

It looks good! Thanks. Just one question: I wonder if we can define a dynamic mapping for aws.*.metrics.*.* like what we do for prometheus metrics, would it be possible (not in this PR)?

Thanks! I think cloudwatch metricset is already using dynamic mapping here 🤔

- name: '*.metrics.*.*'
  type: object
  object_type: double
  object_type_mapping_type: "*"
  description: >
    Metrics that returned from Cloudwatch API query.

@kaiyan-sheng kaiyan-sheng requested a review from ChrsMark April 6, 2021 16:15
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍺

@kaiyan-sheng kaiyan-sheng merged commit 6e6666c into elastic:master Apr 12, 2021
@kaiyan-sheng kaiyan-sheng deleted the fix_test branch April 12, 2021 10:58
kaiyan-sheng added a commit that referenced this pull request Apr 13, 2021
kaiyan-sheng added a commit that referenced this pull request Apr 13, 2021
v1v added a commit to v1v/beats that referenced this pull request Apr 14, 2021
* upstream/master: (308 commits)
  [winlogbeat] Add support for sysmon v13 events 24 and 25 (elastic#24945)
  mergify: add backport label (elastic#25050)
  Add pod.ip in k8s metadata (elastic#25037)
  [elastic-agent] Use fleet.url for container cmd (elastic#25026)
  disable TestXPackEnabled flaky test in logstash metricbeat module (elastic#25034)
  Leverege leader election in agent  k8s manifests (elastic#25016)
  libbeat/publisher/pipeline: expand monitoring (elastic#24700)
  libbeat: fix decode_json_fields config validation (elastic#24862)
  Remove make docs-preview instructions (elastic#25001)
  [Filebeat] Fix IPtables pipeline (elastic#24928)
  [DOCS] cd into correct directory before invoking mage. (elastic#17679)
  Add -buildmode=pie for supported platform (elastic#24964)
  Add agent's direcotry in k8s manifest generator (elastic#24987)
  [mergify] assign the original author (elastic#25007)
  Fix AWS module flaky tests (elastic#24852)
  [filebeat] Use fail_on_template_error on google_workspace and okta pagination (elastic#24967)
  Updated config to match defaults (elastic#25004)
  [Filebeat] Fix hardcoded amazonaws.com endpoint (elastic#24861)
  Add cloud.service.name to add_cloud_metadata (elastic#24993)
  [Ingest Manager] Expose processes and their metrics (elastic#24788)
  ...
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Integrations Label for the Integrations team v7.12.1 v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants