Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat]: ensure synthetics version compatability for suites #24777

Merged
merged 10 commits into from
Apr 21, 2021

Conversation

vigneshshanmugam
Copy link
Member

  • fixes [Heartbeat] Plan for handling synthetics dependencies #22928
  • Loads the synthetics suites and validates if the synthetics version is within the specified range and errors incase of compatibility mismatch. Current I have it set to fixed <2.0.0 to make sure we allow all synthetics version <2.0.0 from all suites directory.

Why is it important?

  • Required for Elastic Synthetics to move towards Beta stage and without this change, we cannot make sure the user specified synthetics version would play well with our heartbeat image.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 26, 2021
@vigneshshanmugam vigneshshanmugam added Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.13.0 labels Mar 26, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 26, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 26, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: andrewvc commented: /test

  • Start Time: 2021-04-20T22:41:39.624+0000

  • Duration: 144 min 37 sec

  • Commit: 4b4d028

Test stats 🧪

Test Results
Failed 0
Passed 2755
Skipped 310
Total 3065

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2755
Skipped 310
Total 3065

Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, left some nits, cleanups, and questions

x-pack/heartbeat/monitors/browser/synthexec/synthexec.go Outdated Show resolved Hide resolved
x-pack/heartbeat/monitors/browser/synthexec/synthexec.go Outdated Show resolved Hide resolved
x-pack/heartbeat/monitors/browser/synthexec/synthexec.go Outdated Show resolved Hide resolved
x-pack/heartbeat/monitors/browser/synthexec/synthexec.go Outdated Show resolved Hide resolved
x-pack/heartbeat/monitors/browser/synthexec/synthexec.go Outdated Show resolved Hide resolved
x-pack/heartbeat/monitors/browser/synthexec/synthexec.go Outdated Show resolved Hide resolved
x-pack/heartbeat/monitors/browser/synthexec/synthexec.go Outdated Show resolved Hide resolved
x-pack/heartbeat/monitors/browser/synthexec/synthexec.go Outdated Show resolved Hide resolved
x-pack/heartbeat/monitors/browser/synthexec/synthexec.go Outdated Show resolved Hide resolved
@vigneshshanmugam
Copy link
Member Author

@andrewvc Any idea why the packaging fails?

@andrewvc
Copy link
Contributor

@elasticmachine merge upstream

Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewvc
Copy link
Contributor

/test

andrewvc pushed a commit to andrewvc/beats that referenced this pull request Apr 21, 2021
…tics version compatability for suites * address review and fix notice * fix lowercase struct * fix version conflict and rebase * update go.* stuff to master * fix notice.txt * move validate inside sourcempatability for suites (elastic#24777)

 fixes elastic#22928
 Loads the synthetics suites and validates if the synthetics version is within the specified range and errors incase of compatibility mismatch. Current I have it set to fixed <2.0.0 to make sure we allow all synthetics version <2.0.0 from all suites directory.

Why is it important?
v1v added a commit to v1v/beats that referenced this pull request Apr 21, 2021
…-github-pr-comment-template

* upstream/master:
  Check native environment before starting (elastic#25186)
  Change event.code and winlog.event_id type (elastic#25176)
  [Ingest Manager] Proxy processes/elastic-agent to stats (elastic#25193)
  Update mergify backporting to 7.x and 7.13 (elastic#25196)
  [Heartbeat]: ensure synthetics version co* [Heartbeat]: ensure synthetics version compatability for suites  * address review and fix notice  * fix lowercase struct  * fix version conflict and rebase  * update go.* stuff to master  * fix notice.txt  * move validate inside sourcempatability for suites (elastic#24777)
  [Filebeat] Ensure Kibana audit `event.category` and `event.type` are still processed as strings. (elastic#25101)
  Update replace.asciidoc (elastic#25055)
  Fix nil panic when overwriting metadata (elastic#24741)
  [Filebeat] Add Malware Bazaar to Threat Intel Module (elastic#24570)
  Fix k8s svc selectors mapping (elastic#25169)
  [Ingest Manager] Make agent retry values for bootstraping configurable (elastic#25163)
  [Metricbeat] Remove elasticsearc.index.created from the SM code (elastic#25113)
v1v added a commit to v1v/beats that referenced this pull request Apr 22, 2021
…ng-versions-stack

* upstream/master: (28 commits)
  Add support for parsers in filestream input (elastic#24763)
  Skip flaky test TestFilestreamTruncate (elastic#25218)
  backport: Add 7.13 branch (elastic#25189)
  Update decode_json_fields.asciidoc (elastic#25056)
  [Elastic Agent] Fix status and inspect command to work inside running container (elastic#25204)
  Check native environment before starting (elastic#25186)
  Change event.code and winlog.event_id type (elastic#25176)
  [Ingest Manager] Proxy processes/elastic-agent to stats (elastic#25193)
  Update mergify backporting to 7.x and 7.13 (elastic#25196)
  [Heartbeat]: ensure synthetics version co* [Heartbeat]: ensure synthetics version compatability for suites  * address review and fix notice  * fix lowercase struct  * fix version conflict and rebase  * update go.* stuff to master  * fix notice.txt  * move validate inside sourcempatability for suites (elastic#24777)
  [Filebeat] Ensure Kibana audit `event.category` and `event.type` are still processed as strings. (elastic#25101)
  Update replace.asciidoc (elastic#25055)
  Fix nil panic when overwriting metadata (elastic#24741)
  [Filebeat] Add Malware Bazaar to Threat Intel Module (elastic#24570)
  Fix k8s svc selectors mapping (elastic#25169)
  [Ingest Manager] Make agent retry values for bootstraping configurable (elastic#25163)
  [Metricbeat] Remove elasticsearc.index.created from the SM code (elastic#25113)
  [Ingest Manager] Keep http and logging config during enroll (elastic#25132)
  Refactor kubernetes autodiscover to avoid skipping short-living pods (elastic#24742)
  [libbeat] New decode xml wineventlog processor (elastic#25115)
  ...
andrewvc pushed a commit to andrewvc/beats that referenced this pull request Apr 22, 2021
…tics version compatability for suites * address review and fix notice * fix lowercase struct * fix version conflict and rebase * update go.* stuff to master * fix notice.txt * move validate inside sourcempatability for suites (elastic#24777)

 fixes elastic#22928
 Loads the synthetics suites and validates if the synthetics version is within the specified range and errors incase of compatibility mismatch. Current I have it set to fixed <2.0.0 to make sure we allow all synthetics version <2.0.0 from all suites directory.

Why is it important?
andrewvc added a commit that referenced this pull request Jul 22, 2021
…tics version compatability for suites * address review and fix notice * fix lowercase struct * fix version conflict and rebase * update go.* stuff to master * fix notice.txt * move validate inside sourcempatability for suites (#24777) (#25200)

fixes #22928
 Loads the synthetics suites and validates if the synthetics version is within the specified range and errors incase of compatibility mismatch. Current I have it set to fixed <2.0.0 to make sure we allow all synthetics version <2.0.0 from all suites directory.

Why is it important?

Co-authored-by: Vignesh Shanmugam <[email protected]>
mergify bot pushed a commit that referenced this pull request Jul 22, 2021
…tics version compatability for suites * address review and fix notice * fix lowercase struct * fix version conflict and rebase * update go.* stuff to master * fix notice.txt * move validate inside sourcempatability for suites (#24777) (#25200)

fixes #22928
 Loads the synthetics suites and validates if the synthetics version is within the specified range and errors incase of compatibility mismatch. Current I have it set to fixed <2.0.0 to make sure we allow all synthetics version <2.0.0 from all suites directory.

Why is it important?

Co-authored-by: Vignesh Shanmugam <[email protected]>
(cherry picked from commit d553335)
andrewvc added a commit that referenced this pull request Jul 23, 2021
…tics version compatability for suites * address review and fix notice * fix lowercase struct * fix version conflict and rebase * update go.* stuff to master * fix notice.txt * move validate inside sourcempatability for suites (#24777) (#25200) (#27027)

fixes #22928
 Loads the synthetics suites and validates if the synthetics version is within the specified range and errors incase of compatibility mismatch. Current I have it set to fixed <2.0.0 to make sure we allow all synthetics version <2.0.0 from all suites directory.

Why is it important?

Co-authored-by: Vignesh Shanmugam <[email protected]>
(cherry picked from commit d553335)

Co-authored-by: Andrew Cholakian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Heartbeat] Plan for handling synthetics dependencies
3 participants