-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Heartbeat] Plan for handling synthetics dependencies #22928
Labels
Heartbeat
Team:obs-ds-hosted-services
Label for the Observability Hosted Services team
test-plan-ok
This PR passed manual testing
v7.13.0
Comments
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Dec 4, 2020
This was referenced Dec 4, 2020
andresrc
added
the
Team:obs-ds-hosted-services
Label for the Observability Hosted Services team
label
Dec 5, 2020
Pinging @elastic/uptime (Team:Uptime) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Dec 5, 2020
In the inline case, you state |
29 tasks
paulb-elastic
added
[zube]: Inbox
[zube]: Ready
v7.13.0
and removed
[zube]: Inbox
labels
Feb 23, 2021
5 tasks
andrewvc
pushed a commit
that referenced
this issue
Apr 21, 2021
…tics version compatability for suites * address review and fix notice * fix lowercase struct * fix version conflict and rebase * update go.* stuff to master * fix notice.txt * move validate inside sourcempatability for suites (#24777) fixes #22928 Loads the synthetics suites and validates if the synthetics version is within the specified range and errors incase of compatibility mismatch. Current I have it set to fixed <2.0.0 to make sure we allow all synthetics version <2.0.0 from all suites directory. Why is it important?
andrewvc
pushed a commit
to andrewvc/beats
that referenced
this issue
Apr 21, 2021
…tics version compatability for suites * address review and fix notice * fix lowercase struct * fix version conflict and rebase * update go.* stuff to master * fix notice.txt * move validate inside sourcempatability for suites (elastic#24777) fixes elastic#22928 Loads the synthetics suites and validates if the synthetics version is within the specified range and errors incase of compatibility mismatch. Current I have it set to fixed <2.0.0 to make sure we allow all synthetics version <2.0.0 from all suites directory. Why is it important?
andrewvc
pushed a commit
to andrewvc/beats
that referenced
this issue
Apr 22, 2021
…tics version compatability for suites * address review and fix notice * fix lowercase struct * fix version conflict and rebase * update go.* stuff to master * fix notice.txt * move validate inside sourcempatability for suites (elastic#24777) fixes elastic#22928 Loads the synthetics suites and validates if the synthetics version is within the specified range and errors incase of compatibility mismatch. Current I have it set to fixed <2.0.0 to make sure we allow all synthetics version <2.0.0 from all suites directory. Why is it important?
I created a custom zip with a suite including a |
justinkambic
added
test-plan-ok
This PR passed manual testing
and removed
test-plan
Add this PR to be manual test plan
labels
May 5, 2021
andrewvc
added a commit
that referenced
this issue
Jul 22, 2021
…tics version compatability for suites * address review and fix notice * fix lowercase struct * fix version conflict and rebase * update go.* stuff to master * fix notice.txt * move validate inside sourcempatability for suites (#24777) (#25200) fixes #22928 Loads the synthetics suites and validates if the synthetics version is within the specified range and errors incase of compatibility mismatch. Current I have it set to fixed <2.0.0 to make sure we allow all synthetics version <2.0.0 from all suites directory. Why is it important? Co-authored-by: Vignesh Shanmugam <[email protected]>
mergify bot
pushed a commit
that referenced
this issue
Jul 22, 2021
…tics version compatability for suites * address review and fix notice * fix lowercase struct * fix version conflict and rebase * update go.* stuff to master * fix notice.txt * move validate inside sourcempatability for suites (#24777) (#25200) fixes #22928 Loads the synthetics suites and validates if the synthetics version is within the specified range and errors incase of compatibility mismatch. Current I have it set to fixed <2.0.0 to make sure we allow all synthetics version <2.0.0 from all suites directory. Why is it important? Co-authored-by: Vignesh Shanmugam <[email protected]> (cherry picked from commit d553335)
andrewvc
added a commit
that referenced
this issue
Jul 23, 2021
…tics version compatability for suites * address review and fix notice * fix lowercase struct * fix version conflict and rebase * update go.* stuff to master * fix notice.txt * move validate inside sourcempatability for suites (#24777) (#25200) (#27027) fixes #22928 Loads the synthetics suites and validates if the synthetics version is within the specified range and errors incase of compatibility mismatch. Current I have it set to fixed <2.0.0 to make sure we allow all synthetics version <2.0.0 from all suites directory. Why is it important? Co-authored-by: Vignesh Shanmugam <[email protected]> (cherry picked from commit d553335) Co-authored-by: Andrew Cholakian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Heartbeat
Team:obs-ds-hosted-services
Label for the Observability Hosted Services team
test-plan-ok
This PR passed manual testing
v7.13.0
This picks up from #22837 and strives to answer the question of how we handle synthetics deps.
There are two situations here:
The proposal this issue sets forth is that:
inline
scripts we bundle the latest version of synthetics available at build time for the release, and use that for all runs unless thesynthetics.version
config variable is set to a specific value.npm install '@elastic/synthetics@${synthetics.version}
letting users use semver syntax like^1.0.0
if they so desire.npm list -g @elastic/synthetics
npm list @elastic/synthetics
that the major version of synthetics does not exceed version 1.npm i
on each update of the suite code to ensure deps are installedThe text was updated successfully, but these errors were encountered: