Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #24129 to 7.x: [ILM][Docs] Clarify how to change setup.ilm.pattern #24395

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Mar 5, 2021

Cherry-pick of PR #24129 to 7.x branch. Original message:

What does this PR do?

Clarify docs about setup.ilm.pattern to make it clear that just changing the pattern and reloading the policy is not enough for the new pattern to take effect.

Why is it important?

To avoid misunderstandings about how to modify the ILM pattern.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Screenshots

Before:

before


After (this PR):

Screen Shot 2021-02-19 at 16 22 23

* ILM: Clarify docs about setup.ilm.pattern

* address review comments

(cherry picked from commit f3dda90)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 5, 2021
@adriansr adriansr requested a review from dedemorton March 5, 2021 15:57
@adriansr adriansr added the review label Mar 5, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24395 opened

  • Start Time: 2021-03-05T15:57:53.469+0000

  • Duration: 20 min 53 sec

  • Commit: 9fb6759

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

@adriansr adriansr added the docs label Mar 10, 2021
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@adriansr adriansr merged commit 04f15d8 into elastic:7.x Mar 11, 2021
@zube zube bot removed the [zube]: Done label Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants