Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ILM][Docs] Clarify how to change setup.ilm.pattern #24129

Merged
merged 2 commits into from
Mar 5, 2021

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Feb 19, 2021

What does this PR do?

Clarify docs about setup.ilm.pattern to make it clear that just changing the pattern and reloading the policy is not enough for the new pattern to take effect.

Why is it important?

To avoid misunderstandings about how to modify the ILM pattern.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Screenshots

Before:

before


After (this PR):

Screen Shot 2021-02-19 at 16 22 23

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 19, 2021
@adriansr adriansr requested review from dedemorton and urso February 19, 2021 15:30
@adriansr adriansr added the Team:Elastic-Agent Label for the Agent team label Feb 19, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 19, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 19, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24129 updated

  • Start Time: 2021-03-02T09:24:26.906+0000

  • Duration: 20 min 53 sec

  • Commit: 0903ada

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change to add to the one suggested by urso.

Otherwise, looks good. Thank you for adding this!

libbeat/docs/shared-ilm.asciidoc Outdated Show resolved Hide resolved
@adriansr adriansr merged commit f3dda90 into elastic:master Mar 5, 2021
@adriansr adriansr added the needs_backport PR is waiting to be backported to other branches. label Mar 5, 2021
adriansr added a commit to adriansr/beats that referenced this pull request Mar 5, 2021
* ILM: Clarify docs about setup.ilm.pattern

* address review comments

(cherry picked from commit f3dda90)
@adriansr adriansr added v7.13.0 and removed needs_backport PR is waiting to be backported to other branches. labels Mar 5, 2021
adriansr added a commit to adriansr/beats that referenced this pull request Mar 5, 2021
* ILM: Clarify docs about setup.ilm.pattern

* address review comments

(cherry picked from commit f3dda90)
adriansr added a commit that referenced this pull request Mar 11, 2021
* ILM: Clarify docs about setup.ilm.pattern

* address review comments

(cherry picked from commit f3dda90)
adriansr added a commit that referenced this pull request Mar 21, 2021
* ILM: Clarify docs about setup.ilm.pattern

* address review comments

(cherry picked from commit f3dda90)

Co-authored-by: DeDe Morton <[email protected]>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…lastic#24396)

* ILM: Clarify docs about setup.ilm.pattern

* address review comments

(cherry picked from commit 54903d8)

Co-authored-by: DeDe Morton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ILM: Change of setup.ilm.pattern is not applied even with setup.ilm.overwrite set.
4 participants