Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #23469 to 7.x: Rename s3 input to aws-s3 input #23573

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Cherry-pick #23469 to 7.x: Rename s3 input to aws-s3 input #23573

merged 1 commit into from
Jan 20, 2021

Conversation

kaiyan-sheng
Copy link
Contributor

Cherry-pick of PR #23469 to 7.x branch. Original message:

What does this PR do?

This PR is to rename Filebeat s3 input to aws-s3 input.
Closes elastic/integrations#488

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  1. Test the Filebeat aws-s3 input:
filebeat.inputs:
- type: aws-s3
  enabled: true
  queue_url: https://sqs.eu-central-1.amazonaws.com/428152502467/filebeat-aws-elb-test
  credential_profile_name: elastic-beats

This should start aws-s3 input with no error.

  1. Test Filebeat filesets that use aws-s3 input:
./filebeat modules enable aws

and change modules.d/aws.yml to enable a fileset in aws module. For example:

- module: aws
  cloudtrail:
    enabled: true
    var.queue_url: https://sqs.us-east-1.amazonaws.com/428152502467/test-fb-ks
    var.credential_profile_name: elastic-beats

Then run Filebeat and you should see no error. If there are new logs going into the S3 which generates new SQS messages in test-fb-ks, you should also see the events in Elasticsearch.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 19, 2021
@botelastic
Copy link

botelastic bot commented Jan 19, 2021

This pull request doesn't have a Team:<team> label.

@kaiyan-sheng kaiyan-sheng self-assigned this Jan 19, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23573 opened

    • Start Time: 2021-01-19T17:09:33.595+0000
  • Duration: 54 min 38 sec

  • Commit: 820be3c

Test stats 🧪

Test Results
Failed 0
Passed 6528
Skipped 586
Total 7114

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6528
Skipped 586
Total 7114

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@kaiyan-sheng kaiyan-sheng merged commit 83051a3 into elastic:7.x Jan 20, 2021
@kaiyan-sheng kaiyan-sheng deleted the backport_23469_7.x branch January 20, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team [zube]: In Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants