-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename s3 input to aws-s3 input #23469
Conversation
Pinging @elastic/integrations (Team:Platforms) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
For the doc build, change this line: It should be:
When I make this change the PR builds locally 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think filebeat/docs/aws-credentials-examples.asciidoc
and x-pack/filebeat/_meta/config/filebeat.inputs.reference.xpack.yml.tmpl
need updating too.
otherwise looks great.
@leehinman Good catch! It's fixed now, thank you! |
What does this PR do?
This PR is to rename Filebeat
s3
input toaws-s3
input.Closes elastic/integrations#488
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
aws-s3
input:This should start
aws-s3
input with no error.aws-s3
input:and change
modules.d/aws.yml
to enable a fileset inaws
module. For example:Then run Filebeat and you should see no error. If there are new logs going into the S3 which generates new SQS messages in
test-fb-ks
, you should also see the events in Elasticsearch.