Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Support Windows-2016 in pipeline 2.0 #21337

Merged
merged 9 commits into from
Oct 8, 2020
Merged

[CI] Support Windows-2016 in pipeline 2.0 #21337

merged 9 commits into from
Oct 8, 2020

Conversation

v1v
Copy link
Member

@v1v v1v commented Sep 28, 2020 •
edited
Loading

What does this PR do?

Pipeline 1.0 is not anymore required since we use a 2.0 pipeline with support for mono-repos.
Enable windows-2016 build/tests for all the beats but filebeat (See #19641)

Why is it important?

Enable windows-2016 builds/tests when merging to branches or tags creation.

When

  • By default on builds from branches.
  • By default on builds from tags.
  • For PRs:
    • if label windows-2016 is added then the following builds will run it.
    • if comment /test <module> for windows-2016" it will trigger a build for windows-2016. matches the beat folder name or x-pack/. For instance /test x-pack/winlogbeat for windows-2016 or /test winlogbeat for windows-2016

@v1v v1v self-assigned this Sep 28, 2020
@v1v v1v added the automation label Sep 28, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 28, 2020
@v1v v1v added :Windows ci Team:Automation Label for the Observability productivity team labels Sep 28, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 28, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 28, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21337 updated]

  • Start Time: 2020-10-06T16:05:45.383+0000

  • Duration: 99 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 15216
Skipped 1663
Total 16879

v1v added 4 commits September 28, 2020 13:35
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-2016
835e53a 
* upstream/master:
  Skip flaky test TestClientPublishEventKerberosAware (elastic#21296)
  [CI] Enable macOS builds for branches/tags (elastic#21323)
  [CI] refactor runbld post build action (elastic#21256)
  [CI] cherry-pick elastic#20891 (elastic#21314)
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-2016
6696ff1 
* upstream/master:
  feat: prepare release pipelines (elastic#21238)
  Add IP validation to Security module (elastic#21325)
  Fixes for new 7.10 rsa2elk datasets (elastic#21240)
  o365input: Restart after fatal error (elastic#21258)
  Fix panic in cgroups monitoring (elastic#21355)
  Handle multiple upstreams in ingress-controller (elastic#21215)
  [CI] Fix runbld when workspace does not exist (elastic#21350)
  [Filebeat] Fix checkpoint (elastic#21344)
  [CI] Archive build reasons (elastic#21347)
  Add dashboard for pubsub metricset in googlecloud module (elastic#21326)
  [Elastic Agent] Allow embedding of certificate (elastic#21179)
  Adds a default for failure_cache.min_ttl (elastic#21085)
  [libbeat] Disk queue implementation (elastic#21176)
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-2016
ff9a47c 
* upstream/master: (27 commits)
  [Ingest Manager] Split index restrictions into type,dataset, namespace parts (elastic#21406)
  Update Filebeat module expected logs files (elastic#21454)
  Edit SQL module docs and fix broken doc structure (elastic#21233)
  [Ingest Manager] Send snapshot flag together with metadata (elastic#21285)
  Revert "[JJBB] Set shallow cloning to 10 (elastic#21409)" (elastic#21447)
  [JJBB] Use reference repo for fast checkouts (elastic#21410)
  Add initial skeleton of filestream input (elastic#21427)
  Initial spec file for apm-server (elastic#21225)
  [Ingest Manager] Upgrade Action: make source URI optional (elastic#21372)
  Add field limit check for AWS Cloudtrail flattened fields (elastic#21388)
  [Winlogbeat] Move winlogbeat javascript processor to libbeat (elastic#21402)
  ci: pipeline to generate the changelog (elastic#21426)
  [JJBB] Set shallow cloning to 10 (elastic#21409)
  docs: add link to release notes for 7.9.2 (elastic#21405) (elastic#21419)
  docs: Prepare Changelog for 7.9.2 (elastic#21229) (elastic#21403)
  fix: mark flaky tests (elastic#21300)
  fix: use a fixed version of setuptools (elastic#21393)
  Move Kubernetes events metricset to its own block in reference config (elastic#21407)
  [libbeat] Enable WriteAheadLimit in the disk queue (elastic#21391)
  docs: fix apt/yum formatting (elastic#21362)
  ...
@v1v
Specific stage for the windows-2016 to only run when merge to branche…
3a21afe 
…s and tags by default
@v1v v1v added windows-2016 Enable builds in the CI for windows-2016 and removed :Windows labels Oct 2, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-2016
07afe0b 
* upstream/master: (26 commits)
  [Ingest Manager] Send updating state (elastic#21461)
  [Filebeat][New Fileset] Cisco Umbrella support (elastic#21504)
  [Ingest Manager] Download asc from artifact store specified in spec (elastic#21488)
  Implementation of fileProspector (elastic#21479)
  [Metricbeat] Add latency config option into aws module (elastic#20875)
  Skip filestream flaky tests (elastic#21490)
  Ignore unsupported metrics in the azure module (elastic#21486)
  Do not run symlink tests on Windows (elastic#21472)
  Map `cloud.account.id` to azure sub id (elastic#21483)
  Add support for app_state metricset (elastic#20639)
  Include original error when metricbeat fails to connect with Kafka (elastic#21484)
  Prompt only when agent is already enrolled (elastic#21473)
  Fix leftover delpoyment example (elastic#21474)
  Bump version to ECS 1.6 in modules without ECS updates (elastic#21455)
  Clarify input type configuration options (elastic#19284)
  Increase index pattern size check to 10MiB (elastic#21487)
  Migrate S3 Input to Filebeat Input V2 (elastic#20005)
  [libbeat] Add configurable exponential backoff for disk queue write errors (elastic#21493)
  Revert "Revert "[JJBB] Set shallow cloning to 10 (elastic#21409)" (elastic#21447)" (elastic#21467)
  Fix format of debug messages in tlscommon (elastic#21482)
  ...
@v1v v1v marked this pull request as ready for review October 5, 2020 16:09
@v1v v1v requested review from a team as code owners October 5, 2020 16:09
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

cachedout
cachedout approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@cachedout cachedout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖️ for the inline comments. Nice work!

@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-2016
fcd6db3 
* upstream/master:
  [CI] Setup git config globally (elastic#21562)
  docs: update generate_fields_docs.py (elastic#21359)
  Add support for additional fields from V2 ALB logs (elastic#21540)
  Move Prometheus query & remote_write to GA (elastic#21507)
  feat: add a new step to run the e2e tests for certain parts of Beats (elastic#21100)
  [Elastic Agent] Add elastic agent ID and version to events from filebeat and metricbeat. (elastic#21543)
  Release cloudfoundry input and processor as GA (elastic#21525)
  [Packetbeat] New SIP protocol (elastic#21221)
  [Filebeat][New Module] Add support for Microsoft MTP / 365 Defender (elastic#21446)
  [Beats][pytest] Asserting if filebeat logs include errors (elastic#20999)
  junipersrx-module initial release (elastic#20017)
  Add a persistent cache for cloudfoundry metadata based on badger (elastic#20775)
  Add missing changelog entry for cisco umbrella (elastic#21550)
  [Elastic Agent] Add upgrade CLI to initiate upgrade of Agent locally (elastic#21425)
  Enable filestream input (elastic#21533)
  Add filestream input reader (elastic#21481)
  [CI] fix 'no matches found within 10000' (elastic#21466)
  Fix billing.go aws.GetStartTimeEndTime (elastic#21531)
@v1v v1v merged commit 38c6a70 into elastic:master Oct 8, 2020
@v1v v1v deleted the feature/windows-2016 branch October 8, 2020 13:09
v1v added a commit to v1v/beats that referenced this pull request Oct 8, 2020
@v1v
[CI] Support Windows-2016 in pipeline 2.0 (elastic#21337)
84a619c
@v1v v1v mentioned this pull request Oct 8, 2020
Merged
v1v added a commit to v1v/beats that referenced this pull request Oct 8, 2020
@v1v
[CI] Support Windows-2016 in pipeline 2.0 (elastic#21337)
307decd
@v1v v1v mentioned this pull request Oct 8, 2020
Merged
v1v added a commit to v1v/beats that referenced this pull request Oct 8, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-2…
942ebc4 
…012-2.0

* upstream/master:
  Fix function that parses from/to/contact headers (elastic#21672)
  [CI] Support Windows-2016 in pipeline 2.0 (elastic#21337)
v1v added a commit to v1v/beats that referenced this pull request Oct 13, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-10
aa4bf15 
* upstream/master: (127 commits)
  Update obs app links (elastic#21682)
  fix: update fleet test suite name (elastic#21738)
  Remove dot from file.extension value in Auditbeat FIM (elastic#21644)
  Fix leaks with metadata processors (elastic#16349)
  Add istiod metricset (elastic#21519)
  [Ingest Manager] Change Sync/Close call order (elastic#21735)
  [Ingest Manager] Syncing unpacked files (elastic#21706)
  Fix concurrent map read and write in socket dataset (elastic#21690)
  Fix conditional coding to remove seccomp info from Winlogbeat (elastic#21652)
  [Elastic Agent] Fix issue where inputs without processors defined would panic (elastic#21628)
  Add configuration of filestream input (elastic#21565)
  libbeat/logp: introduce Logger.WithOptions (elastic#21671)
  Make o365audit input cancellable (elastic#21647)
  fix: remove extra curly brace in script (elastic#21692)
  [Winlogbeat] Remove brittle configuration validation from wineventlog (elastic#21593)
  Fix function that parses from/to/contact headers (elastic#21672)
  [CI] Support Windows-2016 in pipeline 2.0 (elastic#21337)
  Skip publisher flaky tests (elastic#21657)
  backport: add 7.10 branch (elastic#21635)
  [CI: Packaging] fix: push ubi8 images too (elastic#21621)
  ...
v1v added a commit that referenced this pull request Oct 14, 2020
@v1v
[CI] Support Windows-2016 in pipeline 2.0 (#21337) (#21688)
1a0012f
v1v added a commit that referenced this pull request Oct 14, 2020
@v1v
[CI] Support Windows-2016 in pipeline 2.0 (#21337) (#21689)
381845a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuisathaverat kuisathaverat kuisathaverat approved these changes

@mdelapenya mdelapenya mdelapenya approved these changes

@cachedout cachedout cachedout approved these changes

Assignees

@v1v v1v

Labels
automation ci Team:Automation Label for the Observability productivity team windows-2016 Enable builds in the CI for windows-2016
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@v1v @elasticmachine @cachedout @mdelapenya @kuisathaverat