Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubernetes events are collected from the api server #21407

Merged
merged 3 commits into from
Sep 30, 2020
Merged

Kubernetes events are collected from the api server #21407

merged 3 commits into from
Sep 30, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Sep 30, 2020 •
edited
Loading

In the reference configuration the event metricset was in the block of
configurations for kube-state-metrics.

From discuss: https://discuss.elastic.co/t/why-cant-i-get-k8s-event/250320

@jsoriano
Kubernetes events are collected from the api server
fdc8650 
In the reference configuration the event metricset was in the block of
configurations for kube-state-metrics.
@jsoriano jsoriano added bug docs Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. Team:Platforms Label for the Integrations - Platforms team v7.9.0 v6.8.11 v7.10.0 labels Sep 30, 2020
@jsoriano jsoriano requested a review from ChrsMark September 30, 2020 09:19
@jsoriano jsoriano self-assigned this Sep 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 30, 2020
@ChrsMark
Copy link
Member

Hmm, wondering if that's the case actually 🤔 . I see that we use kube_config to create a watcher and watch for events:

beats/metricbeat/module/kubernetes/event/event.go

Line 67 in ef6274d

client, err := kubernetes.GetKubernetesClient(config.KubeConfig)
, no?

@jsoriano
Copy link
Member Author

@ChrsMark kube config is used to connect to the API server, not to kube state metrics, right?

@jsoriano
Copy link
Member Author

Oh, or you mean that actually the event metricset uses the kube config and ignores the rest of config values?

@ChrsMark
Copy link
Member

ChrsMark commented Sep 30, 2020 •
edited
Loading

Oh, or you mean that actually the event metricset uses the kube config and ignores the rest of config values?

Exactly! Initially I thought that his PR aims to make use of hosts for event metricset. Maybe having it standalone would make things more clear?

@jsoriano
Copy link
Member Author

Oh, or you mean that actually the event metricset uses the kube config and ignores the rest of config values?

Exactly! Initially I thought that his PR aims to make use of hosts for event metricset. Maybe having it standalone would make things more clear?

Yep, I am going to do that, this is also how we have it in the reference configuration.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 30, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21407 updated]

  • Start Time: 2020-09-30T09:46:50.386+0000

  • Duration: 58 min 57 sec

@jsoriano jsoriano merged commit cd28ee5 into elastic:master Sep 30, 2020
@jsoriano jsoriano deleted the k8s-metricbeat-events branch September 30, 2020 11:28
jsoriano added a commit to jsoriano/beats that referenced this pull request Sep 30, 2020
@jsoriano
Move Kubernetes events metricset to its own block in reference config (…
e729d04 
…elastic#21407)

In the reference configuration the event metricset was in the block of
configurations for kube-state-metrics.

(cherry picked from commit cd28ee5)
@jsoriano jsoriano mentioned this pull request Sep 30, 2020
Merged
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Sep 30, 2020
@jsoriano jsoriano mentioned this pull request Sep 30, 2020
Merged
jsoriano added a commit to jsoriano/beats that referenced this pull request Sep 30, 2020
@jsoriano
Move Kubernetes events metricset to its own block in reference config (…
97db66d 
…elastic#21407)

In the reference configuration the event metricset was in the block of
configurations for kube-state-metrics.

(cherry picked from commit cd28ee5)
@jsoriano jsoriano mentioned this pull request Sep 30, 2020
Merged
jsoriano added a commit to jsoriano/beats that referenced this pull request Sep 30, 2020
@jsoriano
Move Kubernetes events metricset to its own block in reference config (…
992b2d6 
…elastic#21407)

In the reference configuration the event metricset was in the block of
configurations for kube-state-metrics.

(cherry picked from commit cd28ee5)
jsoriano added a commit that referenced this pull request Sep 30, 2020
@jsoriano
Move Kubernetes events metricset to its own block in reference config (…
2f6bdc5 
…#21407) (#21414)

In the reference configuration the event metricset was in the block of
configurations for kube-state-metrics.

(cherry picked from commit cd28ee5)
jsoriano added a commit that referenced this pull request Sep 30, 2020
@jsoriano
Move Kubernetes events metricset to its own block in reference config (…
966f65c 
…#21407) (#21415)

In the reference configuration the event metricset was in the block of
configurations for kube-state-metrics.

(cherry picked from commit cd28ee5)
jsoriano added a commit that referenced this pull request Sep 30, 2020
@jsoriano
Move Kubernetes events metricset to its own block in reference config (…
9662f15 
…#21407) (#21416)

In the reference configuration the event metricset was in the block of
configurations for kube-state-metrics.

(cherry picked from commit cd28ee5)
v1v added a commit to v1v/beats that referenced this pull request Sep 30, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/2.0-skip-…
cb2bd71 
…ci-build-label-support

* upstream/master:
  [JJBB] Set shallow cloning to 10 (elastic#21409)
  docs: add link to release notes for 7.9.2 (elastic#21405) (elastic#21419)
  docs: Prepare Changelog for 7.9.2 (elastic#21229) (elastic#21403)
  fix: mark flaky tests (elastic#21300)
  fix: use a fixed version of setuptools (elastic#21393)
  Move Kubernetes events metricset to its own block in reference config (elastic#21407)
  [libbeat] Enable WriteAheadLimit in the disk queue (elastic#21391)
  docs: fix apt/yum formatting (elastic#21362)
  Fix shutdown tracking in s3 input (elastic#21380)
  [libbeat] Fix position writing in the disk queue
  Add UBI 8 image to the dependencies report (elastic#21374)
  Fix debug message to show actual SQS message ID (elastic#20614)
  [Elastic Agent] Rename *ConfigChange to PolicyChange (elastic#20779)
  [Elastic Agent] Add install/uninstall sub-command (elastic#21206)
  [Filebeat][httpjson] Make httpjson use cursor input when using date cursor (elastic#20751)
  feat: prepare release pipelines (elastic#21238)
  Add IP validation to Security module (elastic#21325)
v1v added a commit to v1v/beats that referenced this pull request Oct 2, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-2016
ff9a47c 
* upstream/master: (27 commits)
  [Ingest Manager] Split index restrictions into type,dataset, namespace parts (elastic#21406)
  Update Filebeat module expected logs files (elastic#21454)
  Edit SQL module docs and fix broken doc structure (elastic#21233)
  [Ingest Manager] Send snapshot flag together with metadata (elastic#21285)
  Revert "[JJBB] Set shallow cloning to 10 (elastic#21409)" (elastic#21447)
  [JJBB] Use reference repo for fast checkouts (elastic#21410)
  Add initial skeleton of filestream input (elastic#21427)
  Initial spec file for apm-server (elastic#21225)
  [Ingest Manager] Upgrade Action: make source URI optional (elastic#21372)
  Add field limit check for AWS Cloudtrail flattened fields (elastic#21388)
  [Winlogbeat] Move winlogbeat javascript processor to libbeat (elastic#21402)
  ci: pipeline to generate the changelog (elastic#21426)
  [JJBB] Set shallow cloning to 10 (elastic#21409)
  docs: add link to release notes for 7.9.2 (elastic#21405) (elastic#21419)
  docs: Prepare Changelog for 7.9.2 (elastic#21229) (elastic#21403)
  fix: mark flaky tests (elastic#21300)
  fix: use a fixed version of setuptools (elastic#21393)
  Move Kubernetes events metricset to its own block in reference config (elastic#21407)
  [libbeat] Enable WriteAheadLimit in the disk queue (elastic#21391)
  docs: fix apt/yum formatting (elastic#21362)
  ...
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@jsoriano
Move Kubernetes events metricset to its own block in reference config (…
403983d 
…elastic#21407) (elastic#21415)

In the reference configuration the event metricset was in the block of
configurations for kube-state-metrics.

(cherry picked from commit c4b1f04)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@jsoriano jsoriano

Labels
bug docs Metricbeat Metricbeat Team:Platforms Label for the Integrations - Platforms team v6.8.11 v6.8.13 v7.9.0 v7.9.3 v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoriano @elasticmachine @ChrsMark