Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #20448 to 7.x: Update vm_compute metricset with more info on guest metrics #20631

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Cherry-pick #20448 to 7.x: Update vm_compute metricset with more info on guest metrics #20631

merged 1 commit into from
Aug 18, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Aug 17, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #20448 to 7.x branch. Original message:

What does this PR do?

Updates documentation for the compute_vm metricset with more info on the vm 0S guest metrics.
Replaces event output with a generic one coming from the default vm namespace.

Why is it important?

Users expected to have those metrics available by default and on all vm os's.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@narph
Update vm_compute metricset with more info on guest metrics (elastic#…
30ebe6b 
…20448)

* mofidy doc

* update doc

* changelog

(cherry picked from commit dec042c)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 17, 2020
@narph narph self-assigned this Aug 17, 2020
@narph narph added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Aug 17, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 17, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 17, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20631 opened, Started by user Mariana Dima, Rebuilds build #1]

  • Start Time: 2020-08-17T13:50:50.278+0000

  • Duration: 63 min 0 sec

Test stats 🧪

Test Results
Failed 0
Passed 3582
Skipped 797
Total 4379

@narph narph merged commit 4f18a00 into elastic:7.x Aug 18, 2020
@narph narph deleted the backport_20448_7.x branch August 18, 2020 08:25
@zube zube bot removed the [zube]: Done label Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@narph narph

Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narph @elasticmachine @kaiyan-sheng