Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vm_compute metricset with more info on guest metrics #20448

Merged
merged 7 commits into from
Aug 10, 2020
Merged

Update vm_compute metricset with more info on guest metrics #20448

merged 7 commits into from
Aug 10, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Aug 5, 2020

What does this PR do?

Updates documentation for the compute_vm metricset with more info on the vm 0S guest metrics.
Replaces event output with a generic one coming from the default vm namespace.

Why is it important?

Users expected to have those metrics available by default and on all vm os's.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 5, 2020
@narph narph self-assigned this Aug 5, 2020
@narph narph added [zube]: In Review needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team labels Aug 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 5, 2020
@narph narph mentioned this pull request Aug 5, 2020
Closed
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 5, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20448 updated]

  • Start Time: 2020-08-05T11:32:48.759+0000

  • Duration: 62 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 3525
Skipped 818
Total 4343

kaiyan-sheng
kaiyan-sheng approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@narph narph merged commit dec042c into elastic:master Aug 10, 2020
@narph narph deleted the vm-doc branch August 10, 2020 17:20
narph added a commit to narph/beats that referenced this pull request Aug 17, 2020
@narph
Update vm_compute metricset with more info on guest metrics (elastic#…
30ebe6b 
…20448)

* mofidy doc

* update doc

* changelog

(cherry picked from commit dec042c)
@narph narph mentioned this pull request Aug 17, 2020
Merged
6 tasks
narph added a commit to narph/beats that referenced this pull request Aug 17, 2020
@narph
Update vm_compute metricset with more info on guest metrics (elastic#…
d493355 
…20448)

* mofidy doc

* update doc

* changelog

(cherry picked from commit dec042c)
@narph narph mentioned this pull request Aug 17, 2020
Merged
6 tasks
narph added a commit that referenced this pull request Aug 17, 2020
@narph
Update vm_compute metricset with more info on guest metrics (#20448) (#…
73a5056 
…20632)

* mofidy doc

* update doc

* changelog

(cherry picked from commit dec042c)
narph added a commit that referenced this pull request Aug 18, 2020
@narph
Update vm_compute metricset with more info on guest metrics (#20448) (#…
4f18a00 
…20631)

* mofidy doc

* update doc

* changelog

(cherry picked from commit dec042c)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@narph @melchiormoulin
Update vm_compute metricset with more info on guest metrics (elastic#…
3115206 
…20448)

* mofidy doc

* update doc

* changelog
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@narph
Update vm_compute metricset with more info on guest metrics (elastic#…
37717f6 
…20448) (elastic#20632)

* mofidy doc

* update doc

* changelog

(cherry picked from commit 99defac)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@narph narph

Labels
needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narph @elasticmachine @kaiyan-sheng