Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #20254 to 7.x: [Filebeat] Fix event.outcome logic for azure/signinlogs fileset #20608

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman commented Aug 14, 2020

Cherry-pick of PR #20254 to 7.x branch. Original message:

What does this PR do?

  • fix event.outcome logic for azure/siginlogs fileset
  • add GROK pattern for usernames that don't have '@' for
    azure/siginlogs fileset

Why is it important?

  • Bug fix for event.outcome logic
  • some usernames in azure don't have '@'

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

TESTING_FILEBEAT_MODULES=azure TESTING_FILEBEAT_FILESETS=signinlogs mage -v pythonIntegTest

…tic#20254)

* Fix event.outcome logic for azure/signinlogs fileset

- fix event.outcome logic
- add GROK pattern for usernames that don't have '@'

* Add example of principal name without @

Co-authored-by: Andrew Kroh <[email protected]>
(cherry picked from commit dac0534)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 14, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20608 opened]

  • Start Time: 2020-08-14T15:06:35.656+0000

  • Duration: 54 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 2446
Skipped 388
Total 2834

@leehinman leehinman merged commit c203428 into elastic:7.x Aug 18, 2020
@leehinman leehinman deleted the backport_20254_7.x branch October 5, 2020 19:06
@zube zube bot removed the [zube]: Done label Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants