-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Fix event.outcome logic for azure/signinlogs fileset #20254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leehinman
added
bug
Filebeat
Filebeat
needs_backport
PR is waiting to be backported to other branches.
Team:SIEM
labels
Jul 27, 2020
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Jul 27, 2020
- fix event.outcome logic - add GROK pattern for usernames that don't have '@'
5 tasks
Collaborator
andrewkroh
approved these changes
Jul 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It would be good to add a log sample where the user_principal_name doesn't contain the @
.
andrewkroh
approved these changes
Aug 11, 2020
Merged
3 tasks
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
Aug 14, 2020
…tic#20254) * Fix event.outcome logic for azure/signinlogs fileset - fix event.outcome logic - add GROK pattern for usernames that don't have '@' * Add example of principal name without @ Co-authored-by: Andrew Kroh <[email protected]> (cherry picked from commit dac0534)
leehinman
added
v7.10.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Aug 14, 2020
leehinman
added a commit
that referenced
this pull request
Aug 18, 2020
…) (#20608) * Fix event.outcome logic for azure/signinlogs fileset - fix event.outcome logic - add GROK pattern for usernames that don't have '@' * Add example of principal name without @ Co-authored-by: Andrew Kroh <[email protected]> (cherry picked from commit dac0534)
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
…tic#20254) * Fix event.outcome logic for azure/signinlogs fileset - fix event.outcome logic - add GROK pattern for usernames that don't have '@' * Add example of principal name without @ Co-authored-by: Andrew Kroh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
azure/siginlogs fileset
Why is it important?
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally