Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #18666 to 7.8: [Elastic Agent] Fix the platform reporting and the family reporting. #18730

Merged
merged 3 commits into from
May 27, 2020
Merged

Cherry-pick #18666 to 7.8: [Elastic Agent] Fix the platform reporting and the family reporting. #18730

merged 3 commits into from
May 27, 2020

Conversation

ph
Copy link
Contributor

@ph ph commented May 25, 2020

Cherry-pick of PR #18666 to 7.8 branch. Original message:

This PR fixes:

  • Report Family correctly: redhat/debian.
  • Report the platform correctly Centos for Centos instead of redhat.

Fixes: #18665

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ph
[Elastic Agent] Fix the platform reporting and the family reporting. (e…
1f31941 
…lastic#18666)

* [Elastic Agent] Fix the platform reporting and the family reporting.

This PR fixes:

- Report Family correctly: redhat/debian.
- Report the platform correctly Centos for Centos instead of redhat.

Fixes: elastic#18665
(cherry picked from commit 235df7b)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 25, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 25, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18730 opened]

  • Start Time: 2020-05-25T17:22:57.229+0000

  • Duration: 30 min 52 sec

@ph ph requested a review from michalpristas May 27, 2020 15:22
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18730 updated]

  • Start Time: 2020-05-27T15:22:47.258+0000

  • Duration: 31 min 4 sec

blakerouse
blakerouse approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ph ph merged commit 2b41972 into elastic:7.8 May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

@michalpristas michalpristas Awaiting requested review from michalpristas

Assignees

@ph ph

Labels
backport review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ph @elasticmachine @blakerouse