Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centos7 is reported as RHEL by MB/FB #18665

Closed
EricDavisX opened this issue May 20, 2020 · 4 comments · Fixed by #18666
Closed

Centos7 is reported as RHEL by MB/FB #18665

EricDavisX opened this issue May 20, 2020 · 4 comments · Fixed by #18666
Labels

Comments

@EricDavisX
Copy link
Contributor

I'm seeing Centos7 OS reported as the wrong OS RHEL (not surprising right, but its not technically true). I looked for existing bugs and discuss topics but seeing none have logged it for review.

For confirmed bugs, please report:

  1. set up a centos 7 vm
  2. install the Alpha BC 2 Stack and Fleet etc.
  3. deploy the Agent to the centos image and it will return as noted. see this image:
    Centos7-Shows-As-RHEL

I was using older infrastructure to reproduce it, let me know if you don't see this on other CentoS public images!

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 20, 2020
@ph
Copy link
Contributor

ph commented May 20, 2020

This is an issue with go-sysinfo, this is the same library that we use to collect metrics inside metricbeat.

I don't think its high priority, because as you said it's not totally false :)

@andresc I would be tempted to reassign that issues to another team, but I am not sure where it fall.

IIRC @andrewkroh initially created it and I see that @fearful-symmetry committed and fixed a few issues.

@ph ph added the bug label May 20, 2020
@andrewkroh
Copy link
Member

What data backs that UI? Can you share a raw JSON document showing the data?

The host.os.family should be redhat and the host.os.platform should be centos. This is the test case we have for centos 7:

https://github.com/elastic/go-sysinfo/blob/2e4263c5c548ff5352fd86b0a29330fb08b5c98f/providers/linux/os_test.go#L69-L76

@ph
Copy link
Contributor

ph commented May 20, 2020

oh we indeed incorrectly use Platform: info.OS.Family

nevermind thanks @andrewkroh, that would be one line to fix.

ph added a commit to ph/beats that referenced this issue May 20, 2020
This PR fixes:

- Report Family correctly: redhat/debian.
- Report the platform correctly Centos for Centos instead of redhat.

Fixes: elastic#18665
@ph ph closed this as completed in #18666 May 25, 2020
ph added a commit that referenced this issue May 25, 2020
…18666)

* [Elastic Agent] Fix the platform reporting and the family reporting.

This PR fixes:

- Report Family correctly: redhat/debian.
- Report the platform correctly Centos for Centos instead of redhat.

Fixes: #18665
ph added a commit to ph/beats that referenced this issue May 25, 2020
…lastic#18666)

* [Elastic Agent] Fix the platform reporting and the family reporting.

This PR fixes:

- Report Family correctly: redhat/debian.
- Report the platform correctly Centos for Centos instead of redhat.

Fixes: elastic#18665
(cherry picked from commit 235df7b)
ph added a commit to ph/beats that referenced this issue May 25, 2020
…lastic#18666)

* [Elastic Agent] Fix the platform reporting and the family reporting.

This PR fixes:

- Report Family correctly: redhat/debian.
- Report the platform correctly Centos for Centos instead of redhat.

Fixes: elastic#18665
(cherry picked from commit 235df7b)
ph added a commit that referenced this issue May 27, 2020
…18666) (#18731)

* [Elastic Agent] Fix the platform reporting and the family reporting.

This PR fixes:

- Report Family correctly: redhat/debian.
- Report the platform correctly Centos for Centos instead of redhat.

Fixes: #18665
(cherry picked from commit 235df7b)
ph added a commit that referenced this issue May 27, 2020
… and the family reporting. (#18730)

* [Elastic Agent] Fix the platform reporting and the family reporting. (#18666)

* [Elastic Agent] Fix the platform reporting and the family reporting.

This PR fixes:

- Report Family correctly: redhat/debian.
- Report the platform correctly Centos for Centos instead of redhat.

Fixes: #18665
(cherry picked from commit 235df7b)

* Update CHANGELOG.asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants