Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18514 to 7.x: Fix fields in kvm status metricset #18565

Merged
merged 1 commit into from
May 15, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented May 15, 2020

Cherry-pick of PR #18514 to 7.x branch. Original message:

What does this PR do?

  • Add kvm.id and kvm.name fields at the module level, as used by the new status metricset.
  • Remove one redundant level in the status field.
  • Add a TestData.

Why is it important?

Fix fields in new status metricset.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 15, 2020
@botelastic
Copy link

botelastic bot commented May 15, 2020

This issue doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 2325
Skipped 563
Total 2888

@jsoriano jsoriano merged commit 75f78d0 into elastic:7.x May 15, 2020
@jsoriano jsoriano deleted the backport_18514_7.x branch May 15, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants