Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fields in kvm status metricset #18514

Merged
merged 1 commit into from
May 15, 2020
Merged

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented May 14, 2020

What does this PR do?

  • Add kvm.id and kvm.name fields at the module level, as used by the new status metricset.
  • Remove one redundant level in the status field.
  • Add a TestData.

Why is it important?

Fix fields in new status metricset.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@jsoriano jsoriano added review Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. [zube]: In Review Team:Platforms Label for the Integrations - Platforms team v7.8.0 labels May 14, 2020
@jsoriano jsoriano self-assigned this May 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 14, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 3022
Skipped 760
Total 3782

Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Does this require a changelog?

@jsoriano
Copy link
Member Author

lgtm! Does this require a changelog?

Not if this gets backported to 7.8 before 7.8.0, this metricset hasn't been released yet.

@jsoriano jsoriano merged commit b5b2ba0 into elastic:master May 15, 2020
@jsoriano jsoriano deleted the kvm-status-field branch May 15, 2020 09:35
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label May 15, 2020
jsoriano added a commit to jsoriano/beats that referenced this pull request May 15, 2020
jsoriano added a commit to jsoriano/beats that referenced this pull request May 15, 2020
jsoriano added a commit that referenced this pull request May 15, 2020
jsoriano added a commit that referenced this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Metricbeat Metricbeat review Team:Platforms Label for the Integrations - Platforms team v7.8.0 v7.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants