Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic-Agent] Enable more granular control of monitoring #18346

Merged
merged 7 commits into from
May 26, 2020

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented May 7, 2020

What does this PR do?

Followup to #18284 where i was not happy with the form. this allows more granular control of monitoring especially when on partial failures
Instead of having true/false state of monitoring as a whole, this PR allows agent to keep per type state. As a result steps are not generated if not necessary

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Fixes: #18320

@michalpristas michalpristas added elastic-agent Ingest Management:alpha1 Group issues for ingest management alpha1 labels May 7, 2020
@michalpristas michalpristas self-assigned this May 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 7, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 7, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov
    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Result: FAILURE

    • Duration: 1 min 28 sec

    • Start Time: 2020-05-14T06:32:07.049+0000

    • log

@ph ph added needs_backport PR is waiting to be backported to other branches. [zube]: In Review review and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 8, 2020
@michalpristas michalpristas requested review from ph and blakerouse May 14, 2020 14:00
@ph ph removed the elastic-agent label May 19, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18346 updated]

  • Start Time: 2020-05-26T08:42:14.159+0000

  • Duration: 30 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 505
Skipped 127
Total 632

@michalpristas michalpristas merged commit 32a9885 into elastic:master May 26, 2020
michalpristas added a commit to michalpristas/beats that referenced this pull request May 27, 2020
…8346)

[Elastic-Agent] Enable more granular control of monitoring (elastic#18346)
michalpristas added a commit to michalpristas/beats that referenced this pull request May 27, 2020
…8346)

[Elastic-Agent] Enable more granular control of monitoring (elastic#18346)
michalpristas added a commit that referenced this pull request May 27, 2020
…18762)

[Elastic-Agent] Enable more granular control of monitoring (#18346)
michalpristas added a commit that referenced this pull request May 27, 2020
…18763)

[Elastic-Agent] Enable more granular control of monitoring (#18346)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingest Management:alpha1 Group issues for ingest management alpha1 needs_backport PR is waiting to be backported to other branches. review [zube]: In Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Elastic Agent] Use version from release
3 participants