[Elastic-Agent] Stop monitoring on config change #18284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpristas
added
bug
elastic-agent
Ingest Management:beta1
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
botelastic
bot
added
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
|
|
Not sure I fully got your description on what it exactly fixes. Could you rephrase it? |
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
May 7, 2020
* stop monitors * changelog
6 tasks
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
May 7, 2020
* stop monitors * changelog
6 tasks
michalpristas
added
Ingest Management:alpha1
michalpristas
added a commit
that referenced
this pull request
May 7, 2020
michalpristas
added a commit
that referenced
this pull request
May 7, 2020
6 tasks
This was referenced May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a behavior of stopping monitoring.
When agent start with monitoring enabled and then configuration changes to disable monitoring or part of it (metrics/logs) agent need to stop respective beats.
Atm agent wont stop them and keeps them running
Why is it important?
Enable stopping of monitoring
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.