Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #17946 to 7.x: [Metricbeat] remove distribution type metrics from googlecloud #17995

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Cherry-pick #17946 to 7.x: [Metricbeat] remove distribution type metrics from googlecloud #17995

merged 1 commit into from
Apr 27, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

Cherry-pick of PR #17946 to 7.x branch. Original message:

What does this PR do?

This PR is to remove collecting metrics from googlecloud that are distribution type. Distribution contains summary statistics for a population of values. It optionally contains a histogram representing the distribution of those values across a set of buckets.

Why is it important?

Right now we don't have support for histogram in googlecloud metricbeat module. When collecting distribution type metrics, they show up like this in ElasticSearch:
Screen Shot 2020-04-23 at 8 34 18 AM

We will need to add support for ES histogram to support this type of metrics from google cloud. Right now, we should remove them till we have the histogram support added in a seperate PR.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

* remove distribution type metrics from googlecloud

(cherry picked from commit 5e18850)
@kaiyan-sheng kaiyan-sheng self-assigned this Apr 25, 2020
@kaiyan-sheng kaiyan-sheng added the Team:Platforms Label for the Integrations - Platforms team label Apr 25, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@kaiyan-sheng kaiyan-sheng merged commit f8f9a66 into elastic:7.x Apr 27, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_17946_7.x branch April 27, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport review Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants