Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] remove distribution type metrics from googlecloud #17946

Merged
merged 3 commits into from
Apr 24, 2020
Merged

[Metricbeat] remove distribution type metrics from googlecloud #17946

merged 3 commits into from
Apr 24, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

What does this PR do?

This PR is to remove collecting metrics from googlecloud that are distribution type. Distribution contains summary statistics for a population of values. It optionally contains a histogram representing the distribution of those values across a set of buckets.

Why is it important?

Right now we don't have support for histogram in googlecloud metricbeat module. When collecting distribution type metrics, they show up like this in ElasticSearch:
Screen Shot 2020-04-23 at 8 34 18 AM

We will need to add support for ES histogram to support this type of metrics from google cloud. Right now, we should remove them till we have the histogram support added in a seperate PR.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kaiyan-sheng kaiyan-sheng self-assigned this Apr 23, 2020
@kaiyan-sheng kaiyan-sheng added Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. review Team:Platforms Label for the Integrations - Platforms team labels Apr 23, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

blakerouse
blakerouse approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kaiyan-sheng kaiyan-sheng mentioned this pull request Apr 24, 2020
Closed
@kaiyan-sheng kaiyan-sheng merged commit 5e18850 into elastic:master Apr 24, 2020
@kaiyan-sheng kaiyan-sheng deleted the remove_distribution_type branch April 24, 2020 17:46
@kaiyan-sheng kaiyan-sheng mentioned this pull request Apr 25, 2020
Merged
6 tasks
@kaiyan-sheng kaiyan-sheng added v7.8.0 and removed needs_backport PR is waiting to be backported to other branches. labels Apr 25, 2020
kaiyan-sheng added a commit that referenced this pull request Apr 27, 2020
@kaiyan-sheng
[Metricbeat] remove distribution type metrics from googlecloud (#17946)…
f8f9a66 
… (#17995)

* remove distribution type metrics from googlecloud

(cherry picked from commit 5e18850)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
Metricbeat Metricbeat review Team:Platforms Label for the Integrations - Platforms team v7.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaiyan-sheng @elasticmachine @blakerouse