Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cisco.asciidoc #17856

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Update cisco.asciidoc #17856

merged 2 commits into from
Apr 22, 2020

Conversation

fdartayre
Copy link
Contributor

What does this PR do?

Fix a typo: the setting is script.cache.max_size and not script.cache_max_size

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@andrewkroh
Copy link
Member

run tests

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewkroh andrewkroh changed the base branch from 7.6 to master April 22, 2020 13:47
@andrewkroh andrewkroh added the needs_backport PR is waiting to be backported to other branches. label Apr 22, 2020
@andrewkroh andrewkroh merged commit fd743e8 into master Apr 22, 2020
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels Apr 22, 2020
@andrewkroh
Copy link
Member

andrewkroh commented Apr 22, 2020

I ran mage update on this to fix the build, but didn't realize that it contained an edit to generated file rather than the source. So the update undid that change leaving an empty commit. oops

I'll open another PR to really fix the docs this time.

@andrewkroh andrewkroh removed the needs_backport PR is waiting to be backported to other branches. label Apr 22, 2020
andrewkroh pushed a commit to andrewkroh/beats that referenced this pull request Apr 22, 2020
Fix a typo in the Filebeat Cisco module docs. The setting is script.cache.max_size and not script.cache_max_size.

Fixes elastic#17856
andrewkroh added a commit that referenced this pull request Apr 22, 2020
Fix a typo in the Filebeat Cisco module docs. The setting is script.cache.max_size and not script.cache_max_size.

Fixes #17856

Co-authored-by: Frederic Dartayre <[email protected]>
andrewkroh added a commit to andrewkroh/beats that referenced this pull request Apr 22, 2020
Fix a typo in the Filebeat Cisco module docs. The setting is script.cache.max_size and not script.cache_max_size.

Fixes elastic#17856

Co-authored-by: Frederic Dartayre <[email protected]>
(cherry picked from commit 61fe9fc)
andrewkroh added a commit that referenced this pull request Apr 22, 2020
Fix a typo in the Filebeat Cisco module docs. The setting is script.cache.max_size and not script.cache_max_size.

Fixes #17856

Co-authored-by: Frederic Dartayre <[email protected]>
(cherry picked from commit 61fe9fc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants