Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #16077 to 7.x: Enable netinfo in add metadata processors #16398

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

jsoriano
Copy link
Member

Cherry-pick of PR #16077 to 7.x branch. Original message:

What does this PR do?

Enable netinfo in add_host_metadata and add_observer_metadata processors by default.

Why is it important?

This network information metadata is used in observability solutions.

This change shouldn't break backwards compatibility or produce any conflict as the added fields are in ECS.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

How to test this PR locally

  • Run a beat with the add_host_metadata processor without any options.
  • Check that all events contain host.ip and host.mac fields.

Related issues

Enable netinfo in add_host_metadata and add_observer_metadata processors
by default. This network information metadata is used in observability solutions.

Co-authored-by: Dan Roscigno <[email protected]>
(cherry picked from commit 4ea0f91)
@jsoriano jsoriano merged commit a6dd4c4 into elastic:7.x Feb 19, 2020
@jsoriano jsoriano deleted the backport_16077_7.x branch February 19, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants