Enable netinfo in add metadata processors #16077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
enhancement
review
libbeat
[zube]: In Review
Team:Platforms
Co-Authored-By: DanRoscigno <[email protected]>
jsoriano
force-pushed
the
netinfo-enabled-by-default
branch
from
25ebbb8 to
05cfe97
Compare
jsoriano
added
needs_backport
kaiyan-sheng
reviewed
Feb 4, 2020
libbeat/processors/add_host_metadata/docs/add_host_metadata.asciidoc
Outdated
Show resolved
Hide resolved
andrewkroh
approved these changes
Feb 5, 2020
Yep, I had similar thoughts #15347 (comment) |
|
I have made the same change in |
jsoriano
changed the title
|
Failing test is also failing in master, it seems to be related to a change in ES 8.0 snapshots (#16139). |
kaiyan-sheng
approved these changes
Feb 6, 2020
andrewkroh
approved these changes
Feb 7, 2020
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Feb 18, 2020
Enable netinfo in add_host_metadata and add_observer_metadata processors by default. This network information metadata is used in observability solutions. Co-authored-by: Dan Roscigno <[email protected]> (cherry picked from commit 4ea0f91)
5 tasks
jsoriano
removed
the
needs_backport
jsoriano
added a commit
that referenced
this pull request
Feb 19, 2020
Enable netinfo in add_host_metadata and add_observer_metadata processors by default. This network information metadata is used in observability solutions. (cherry picked from commit 4ea0f91) Co-authored-by: Dan Roscigno <[email protected]>
kvch
pushed a commit
to kvch/beats
that referenced
this pull request
Feb 20, 2020
Enable netinfo in add_host_metadata and add_observer_metadata processors by default. This network information metadata is used in observability solutions. Co-authored-by: Dan Roscigno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable netinfo in add_host_metadata and add_observer_metadata processors by default.
Why is it important?
This network information metadata is used in observability solutions.
This change shouldn't break backwards compatibility or produce any conflict as the added fields are in ECS.
Checklist
How to test this PR locally
add_host_metadataprocessor without any options.host.ipandhost.macfields.Related issues