Do not collect Google Cloud metadata #15806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compute instances metadata may contain sensitive info, so we should not collect them. In the future we can enable this again with some kind of whitelisting, to only report the metadata we want.
exekias
added
bug
needs_backport
sayden
approved these changes
Jan 24, 2020
I don't think so, the previous change has not shipped yet. |
jsoriano
approved these changes
Jan 24, 2020
jsoriano
approved these changes
Jan 24, 2020
exekias
pushed a commit
to exekias/beats
that referenced
this pull request
Jan 24, 2020
* Do not collect Google Cloud metadata Compute instances metadata may contain sensitive info, so we should not collect them. In the future we can enable this again with some kind of whitelisting, to only report the metadata we want. * Update docs (cherry picked from commit 7296437)
4 tasks
exekias
added
v7.6.0
and removed
needs_backport
exekias
pushed a commit
to exekias/beats
that referenced
this pull request
Jan 24, 2020
* Do not collect Google Cloud metadata Compute instances metadata may contain sensitive info, so we should not collect them. In the future we can enable this again with some kind of whitelisting, to only report the metadata we want. * Update docs (cherry picked from commit 7296437)
4 tasks
exekias
pushed a commit
that referenced
this pull request
Jan 25, 2020
* Do not collect Google Cloud metadata Compute instances metadata may contain sensitive info, so we should not collect them. In the future we can enable this again with some kind of whitelisting, to only report the metadata we want. * Update docs (cherry picked from commit 7296437)
exekias
pushed a commit
that referenced
this pull request
Jan 27, 2020
* Do not collect Google Cloud metadata Compute instances metadata may contain sensitive info, so we should not collect them. In the future we can enable this again with some kind of whitelisting, to only report the metadata we want. * Update docs (cherry picked from commit 7296437)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Compute instances metadata may contain sensitive info, so we should not
collect them.
In the future we can enable this again with some kind of whitelisting,
to only report the metadata we want.
Why is it important?
We should avoid collecting sensitive info
Checklist
- [ ] I have added tests that prove my fix is effective or that my feature worksHow to test this PR locally
Configure Metricbeat against a GCloud project that has Compute VMs with metadata, check that we are not collecting it.
Related issues