Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] googlecloud module has potential sensitive data in labels.metadata #15782

Closed
kaiyan-sheng opened this issue Jan 23, 2020 · 2 comments · Fixed by #15806
Closed

[Metricbeat] googlecloud module has potential sensitive data in labels.metadata #15782

kaiyan-sheng opened this issue Jan 23, 2020 · 2 comments · Fixed by #15806
Labels
blocker bug discuss Issue needs further discussion. Metricbeat Metricbeat Team:Integrations Label for the Integrations team

Comments

@kaiyan-sheng
Copy link
Contributor

When testing googlecloud module, I see in each event there are large amount of metadata included. For example, CA_CERT, KUBELET_CERT, KUBELET_KEY under googlecloud.labels.metadata.kube-env. Should we reconsider the metadata under googlecloud.labels.metadata.*?

If you use config below, you should be able to get the metrics that contain these information:

- module: googlecloud
  metricsets:
    - compute
  zone: "europe-west1-c"
  project_id: elastic-observability
  credentials_file_path: "<path-to-your-creds-file>"
  exclude_labels: false
  period: 300s
@kaiyan-sheng kaiyan-sheng added bug discuss Issue needs further discussion. Metricbeat Metricbeat Team:Integrations Label for the Integrations team labels Jan 23, 2020
@kaiyan-sheng
Copy link
Contributor Author

@jsoriano made a suggestion to whitelist the default metadata keys that we consider more useful.

@exekias
Copy link
Contributor

exekias commented Jan 24, 2020

I'm labeling this as a blocker. I think we should remove labels.metadata for now and think about adding it with proper whitelisting in a future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug discuss Issue needs further discussion. Metricbeat Metricbeat Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants