Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Add monitor.timespan field (#14778) #15133

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

andrewvc
Copy link
Contributor

This field is needed to optimize the overview page queries. By adding the time range this monitor is responsible for we can use a range query to substantially narrow the candidate document set in queries.

This takes over from the experiments in #13672 and should be production quality. It only adds this single necessary field.

(cherry picked from commit 416aab0)

This field is needed to optimize the overview page queries. By adding the time range this monitor is responsible for we can use a range query to substantially narrow the candidate document set in queries.

This takes over from the experiments in elastic#13672 and should be production quality. It only adds this single necessary field.

(cherry picked from commit 416aab0)
@andrewvc andrewvc added backport Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels Dec 16, 2019
@andrewvc andrewvc requested a review from ruflin December 16, 2019 21:01
@andrewvc andrewvc requested a review from a team as a code owner December 16, 2019 21:01
@andrewvc andrewvc self-assigned this Dec 16, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (:uptime)

Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a clean backport, only skimmed through it. LGTM.

@@ -30,6 +30,8 @@ import (
"strings"
"testing"

"github.com/elastic/beats/heartbeat/hbtestllext"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@andrewvc andrewvc merged commit 59d3197 into elastic:7.x Dec 18, 2019
@andrewvc andrewvc deleted the backport_14778_7.x branch December 18, 2019 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants