[Heartbeat] Report next_run info per event #13672

andrewvc · 2019-09-13T14:30:04Z

Add support for next_run and next_run_in fields to the monitors object in events. This allows for the computation of SLA statistics in elasticsearch.

Add support for `next_run` and `next_run_in` fields to the monitors object in events. This allows for the computation of SLA statistics in elasticsearch.

elasticmachine · 2019-09-13T14:30:07Z

Pinging @elastic/uptime

heartbeat/hbtestllext/validators.go

heartbeat/hbtestllext/isdefs.go

heartbeat/hbtestllext/validators.go

heartbeat/hbtestllext/isdefs.go

ruflin · 2019-09-16T11:25:43Z

heartbeat/_meta/fields.common.yml

@@ -63,6 +63,21 @@
          description: >
            A token unique to a simultaneously invoked group of checks as in the case where multiple IPs are checked for a single DNS entry.

+        - name: next_run


I normally stumble over names which are foo and foo_bar as it seems foo should probably be an object because the two are somehow related. I guess this is the case here, but not sure what I should recommend as a name ...

BTW: 100% personal preference.

I think I also missed the reasoning why we need both. Wouldn't one be enough?

That's a good point. I think we only need next_run_in. This is in support of timelines in the future. Let me leave this PR open for now, when we get the Kibana side of this going and we're sure this does everything we need I can come back to this and merge it.

SGTM. Ping me when I should have a look again.

ruflin

Code wise LGTM. Left one question.

Could you make hound happy?

ruflin · 2019-09-16T11:26:32Z

heartbeat/monitors/pluginconf.go

@@ -20,6 +20,8 @@ package monitors
 import (
 	"github.com/pkg/errors"

+	"github.com/elastic/beats/heartbeat/scheduler/schedule"
+


houndci-bot · 2019-10-28T18:46:43Z

heartbeat/scheduler/schedule/schedule.go

@@ -55,7 +61,7 @@ func Parse(in string) (*Schedule, error) {
 	return &Schedule{s}, nil
 }

-func (s intervalScheduler) Next(t time.Time) time.Time {
+func (s IntervalScheduler) Next(t time.Time) time.Time {


exported method IntervalScheduler.Next should have comment or be unexported

houndci-bot · 2019-10-28T18:46:44Z

heartbeat/scheduler/schedule/schedule.go

 	interval time.Duration
 }

+func (s IntervalScheduler) QuantizedPeriod(now time.Time) (gte time.Time, lt time.Time) {


exported method IntervalScheduler.QuantizedPeriod should have comment or be unexported

houndci-bot · 2019-10-28T18:46:44Z

heartbeat/scheduler/schedule/schedule.go

@@ -29,10 +31,14 @@ type Schedule struct {
 	scheduler.Schedule
 }

-type intervalScheduler struct {
+type IntervalScheduler struct {


exported type IntervalScheduler should have comment or be unexported

houndci-bot · 2019-10-28T18:46:44Z

heartbeat/scheduler/schedule/quantize/quantize.go

+
+import "time"
+
+func Quantize(t time.Time, period time.Duration) (start time.Time, end time.Time) {


exported function Quantize should have comment or be unexported

This field is needed to optimize the overview page queries. By adding the time range this monitor is responsible for we can use a range query to substantially narrow the candidate document set in queries. This takes over from the experiments in #13672 and should be production quality. It only adds this single necessary field.

This field is needed to optimize the overview page queries. By adding the time range this monitor is responsible for we can use a range query to substantially narrow the candidate document set in queries. This takes over from the experiments in elastic#13672 and should be production quality. It only adds this single necessary field. (cherry picked from commit 416aab0)

This field is needed to optimize the overview page queries. By adding the time range this monitor is responsible for we can use a range query to substantially narrow the candidate document set in queries. This takes over from the experiments in #13672 and should be production quality. It only adds this single necessary field. (cherry picked from commit 416aab0)

mergify · 2021-04-07T16:32:36Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b periods upstream/periods
git merge upstream/master
git push upstream periods

mergify · 2021-09-22T13:07:31Z

This pull request does not have a backport label. Could you fix it @andrewvc? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

jlind23 · 2022-03-31T14:22:44Z

@andrewvc - Closing this one as there were no activity for a while

[Heartbeat] Report next_run info per event

b46f81d

Add support for `next_run` and `next_run_in` fields to the monitors object in events. This allows for the computation of SLA statistics in elasticsearch.

andrewvc added enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels Sep 13, 2019

andrewvc requested a review from ruflin September 13, 2019 14:30

andrewvc requested a review from a team as a code owner September 13, 2019 14:30

andrewvc self-assigned this Sep 13, 2019

houndci-bot reviewed Sep 13, 2019

View reviewed changes

heartbeat/hbtestllext/validators.go Show resolved Hide resolved

heartbeat/hbtestllext/isdefs.go Show resolved Hide resolved

houndci-bot reviewed Sep 13, 2019

View reviewed changes

heartbeat/hbtestllext/validators.go Show resolved Hide resolved

heartbeat/hbtestllext/isdefs.go Show resolved Hide resolved

Add changelog

e90a046

ruflin reviewed Sep 16, 2019

View reviewed changes

Incorporate PR feedback

cdeac64

andrewvc mentioned this pull request Sep 25, 2019

Downtime for SLA-Reporting elastic/uptime#15

Closed

andrewvc added [zube]: Backlog and removed [zube]: Backlog labels Oct 23, 2019

andrewvc mentioned this pull request Oct 26, 2019

Quantized queries elastic/kibana#49442

Closed

andrewvc added 2 commits October 28, 2019 13:46

Checkpoint

077be58

Checkpoint

b06323f

houndci-bot reviewed Oct 28, 2019

View reviewed changes

andrewvc mentioned this pull request Nov 26, 2019

[Heartbeat] Add monitor.timespan field #14778

Merged

andrewvc mentioned this pull request Dec 16, 2019

[Heartbeat] Add monitor.timespan field (#14778) #15133

Merged

mergify bot added the backport-skip Skip notification from the automated backport with mergify label Sep 22, 2021

jlind23 closed this Mar 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Heartbeat] Report next_run info per event #13672

[Heartbeat] Report next_run info per event #13672

andrewvc commented Sep 13, 2019

elasticmachine commented Sep 13, 2019

ruflin Sep 16, 2019 •

edited

Loading

andrewvc Sep 18, 2019

ruflin Sep 18, 2019

ruflin left a comment

ruflin Sep 16, 2019

houndci-bot Oct 28, 2019

houndci-bot Oct 28, 2019

houndci-bot Oct 28, 2019

houndci-bot Oct 28, 2019

mergify bot commented Apr 7, 2021

mergify bot commented Sep 22, 2021

jlind23 commented Mar 31, 2022


		import "time"

		func Quantize(t time.Time, period time.Duration) (start time.Time, end time.Time) {

[Heartbeat] Report next_run info per event #13672

[Heartbeat] Report next_run info per event #13672

Conversation

andrewvc commented Sep 13, 2019

elasticmachine commented Sep 13, 2019

ruflin Sep 16, 2019 • edited Loading

Choose a reason for hiding this comment

andrewvc Sep 18, 2019

Choose a reason for hiding this comment

ruflin Sep 18, 2019

Choose a reason for hiding this comment

ruflin left a comment

Choose a reason for hiding this comment

ruflin Sep 16, 2019

Choose a reason for hiding this comment

houndci-bot Oct 28, 2019

Choose a reason for hiding this comment

houndci-bot Oct 28, 2019

Choose a reason for hiding this comment

houndci-bot Oct 28, 2019

Choose a reason for hiding this comment

houndci-bot Oct 28, 2019

Choose a reason for hiding this comment

mergify bot commented Apr 7, 2021

mergify bot commented Sep 22, 2021

jlind23 commented Mar 31, 2022

ruflin Sep 16, 2019 •

edited

Loading