Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM] Parse enrollment_token response correctly #11648

Merged
merged 8 commits into from
Apr 8, 2019

Conversation

michalpristas
Copy link
Contributor

Followup to #11377

Fixes enrollment token response to be parsed correctly according to a new response format

Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!

@ph ph added the Management label Apr 4, 2019
@ph
Copy link
Contributor

ph commented Apr 4, 2019

Jenkins test this please

@ph
Copy link
Contributor

ph commented Apr 4, 2019

I've rekick the jenkins test suite, I saw a weird error with the runbld execution.

@michalpristas
Copy link
Contributor Author

@ph this is how i found out, i enabled the tests which were disabled and all of them started failing on enroll.

@michalpristas
Copy link
Contributor Author

Jenkins test this please

@ph
Copy link
Contributor

ph commented Apr 5, 2019

@michalpristas we seen to have a few problem with dockers images in tests, lets try to run them again.

But looking at the x-pack/libbeat tests I think we are fine.

----------------------------------------------------------------------
XML: /go/src/github.com/elastic/beats/x-pack/libbeat/build/TEST-system.xml
[success] 50.51% test_management.TestManagement.test_fetch_configs: 15.0651s
[success] 42.29% test_management.TestManagement.test_configs_cache: 12.6123s
[success] 6.58% test_management.TestManagement.test_enroll: 1.9617s
[success] 0.63% test_management.TestManagement.test_enroll_bad_pw: 0.1868s
----------------------------------------------------------------------
Ran 4 tests in 29.833s

@ph
Copy link
Contributor

ph commented Apr 5, 2019

ava.nio.file.InvalidPathException: Malformed input or input contains unmappable characters: /var/lib/jenkins/workspace/elastic+beats+pull-request+multijob-linux/beat/x-pack/libbeat/label/linux-immutable/src/github.com/elastic/beats/x-pack/libbeat/build/system-tests/run/test_management.TestManagement.test_enroll/mockbeat.yml.���.bak

I think its a bug I've introduced in #11034

@michalpristas
Copy link
Contributor Author

looks like it will get green now

@michalpristas michalpristas merged commit 4cc4eee into elastic:master Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants